net: Don't merge HTTP headers and body if the body is not in memory.

net/http/http_stream_parser.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_STREAM_PARSER_H_
 #define NET_HTTP_HTTP_STREAM_PARSER_H_
 #pragma once
 
 #include <string>
 
@@ skipping 73 matching lines @@
   // be large enough to store the encoded chunk, which is payload.size() +
   // kChunkHeaderFooterSize. Returns ERR_INVALID_ARGUMENT if |output_size|
   // is not large enough.
   //
   // The output will look like: "HEX\r\n[payload]\r\n"
   // where HEX is a length in hexdecimal (without the "0x" prefix).
   static int EncodeChunk(const base::StringPiece& payload,
                          char* output,
                          size_t output_size);
 
+  // Returns true if request and body should be merged (i.e. the sum is

[wtc, 2012/01/24 19:08:04]

Note: 'request' consists of 'request headers' and 'request body',
so this comment needs to be more verbose to be accurate:
  Returns true if request headers and body should be merged...

+  // small enough and the body is in memory, and not chunked).
+  static bool ShouldMerge(const std::string& request,

[wtc, 2012/01/24 19:08:04]

The 'request' parameter should be renamed 'request_headers'.

Nit: this method name should say what should be merged.
For example, ShouldMergeRequestBody or the more verbose
ShouldMergeRequestHeadersAndBody.

[satorux1, 2012/01/24 19:25:42]

I like the idea and chose the latter.

+                          const UploadDataStream* request_body);
+
   // The number of extra bytes required to encode a chunk.
   static const size_t kChunkHeaderFooterSize;
 
  private:
   // FOO_COMPLETE states implement the second half of potentially asynchronous
   // operations and don't necessarily mean that FOO is complete.
   enum State {
     STATE_NONE,
     STATE_SENDING_HEADERS,
     // If the request comes with a body, either of the following two
@@ skipping 119 matching lines @@
   size_t chunk_length_;
   size_t chunk_length_without_encoding_;
   bool sent_last_chunk_;
 
   DISALLOW_COPY_AND_ASSIGN(HttpStreamParser);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_STREAM_PARSER_H_