Issue 9264002: aura: Add Ctrl-Shift-Q for quit and Ctrl-Shift-L for lock in chromeos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9264002: aura: Add Ctrl-Shift-Q for quit and Ctrl-Shift-L for lock in chromeos. (Closed)

Created:
8 years, 11 months ago by sadrul

Modified:
8 years, 11 months ago

Reviewers:
pkotwicz, sky, Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

aura: Add Ctrl-Shift-Q for quit and Ctrl-Shift-L for lock in chromeos. BUG=105964, 106873 TEST=manually

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -5 lines)			Patch
M	ash/app_list/app_list.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	ash/wm/activation_controller.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chrome_browser_main_extra_parts_aura.h	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download
M	chrome/browser/chrome_browser_main_extra_parts_aura.cc	View	1	4 chunks	+36 lines, -1 line	2 comments	Download

Total messages: 3 (0 generated)

sadrul

I started on this before I realized Peter had fixes up for review: http://codereview.chromium.org/9124021/, and ...

8 years, 11 months ago (2012-01-19 04:26:50 UTC) #1

sky

The NULL checks seems indicative another problem and I'm not sure they are right. Seems ...

8 years, 11 months ago (2012-01-19 05:02:12 UTC) #2

Ben Goodger (Google)

8 years, 11 months ago (2012-01-19 22:59:48 UTC) #3

I like Peter's approach more - it integrates with the existing key shortcut
handling we have.