Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 9124021: Adds Ctrl-Shift-Q support inside AppList (Closed)

Created:
8 years, 11 months ago by pkotwicz
Modified:
8 years, 11 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Changes as requested #

Patch Set 3 : Removed extraneous import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 5 chunks +13 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ash/shell/shell_main.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ash/shell_delegate.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/accelerator_table.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/aura/chrome_shell_delegate.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/aura/chrome_shell_delegate.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pkotwicz
Adds support for Ctrl-Shift-Q inside AppList. This is the same patch as before except merged. ...
8 years, 11 months ago (2012-01-06 23:20:23 UTC) #1
pkotwicz
Changes as per our discussion on Thursday
8 years, 11 months ago (2012-01-20 15:19:08 UTC) #2
Ben Goodger (Google)
lgtm
8 years, 11 months ago (2012-01-20 15:44:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/9124021/5001
8 years, 11 months ago (2012-01-20 18:03:14 UTC) #4
commit-bot: I haz the power
Try job failure for 9124021-5001 (retry) on mac_rel for step "ui_tests". It's a second try, ...
8 years, 11 months ago (2012-01-20 20:36:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/9124021/5001
8 years, 11 months ago (2012-01-20 20:51:18 UTC) #6
commit-bot: I haz the power
Change committed as 118540
8 years, 11 months ago (2012-01-20 23:08:49 UTC) #7
sadrul
Empty bug-description = ew!
8 years, 11 months ago (2012-01-23 18:00:54 UTC) #8
Nico
8 years, 11 months ago (2012-01-24 17:36:13 UTC) #9
Please don't commit changelists that have no change description.

Powered by Google App Engine
This is Rietveld 408576698