Issue 9132004: Makes Ctrl-Shift-L work in AppList

Issue 9132004: Makes Ctrl-Shift-L work in AppList (Closed)

Created:
8 years, 11 months ago by pkotwicz

Modified:
8 years, 11 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adds an accelerator to handle Ctrl-Shift-L during weird cases BUG=106873 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118747

Patch Set 1 #

Patch Set 2 : Nicer diff #

Patch Set 3 : Changes as requested #

Patch Set 4 : fixed accelerator_table #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -1 line)			Patch
M	ash/accelerators/accelerator_controller.cc	View	1 2	5 chunks	+21 lines, -0 lines	0 comments	Download
M	ash/accelerators/accelerator_controller_unittest.cc	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ash/shell/shell_main.cc	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	ash/shell_delegate.h	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ash/test/test_shell_delegate.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ash/test/test_shell_delegate.cc	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/accelerator_table.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/aura/chrome_shell_delegate.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/aura/chrome_shell_delegate.cc	View	1 2	2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/9132004/7001

8 years, 11 months ago (2012-01-20 23:28:39 UTC) #4

commit-bot: I haz the power

Can't apply patch for file ash/accelerators/accelerator_controller.cc. While running patch -p1 --forward --force; patching file ash/accelerators/accelerator_controller.cc ...

8 years, 11 months ago (2012-01-20 23:28:42 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/9132004/7001

8 years, 11 months ago (2012-01-21 02:43:15 UTC) #6

commit-bot: I haz the power

8 years, 11 months ago (2012-01-21 02:43:17 UTC) #7

Can't apply patch for file ash/accelerators/accelerator_controller.cc.
While running patch -p1 --forward --force;
patching file ash/accelerators/accelerator_controller.cc
Hunk #1 FAILED at 9.
Hunk #2 FAILED at 25.
Hunk #3 FAILED at 45.
Hunk #4 succeeded at 79 (offset 11 lines).
Hunk #5 succeeded at 218 (offset 13 lines).
3 out of 5 hunks FAILED -- saving rejects to file
ash/accelerators/accelerator_controller.cc.rej

Expand Messages | Collapse Messages