Issue 9235021: Use a 'defines' block instead of adding -Dfoo to cflags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9235021: Use a 'defines' block instead of adding -Dfoo to cflags. (Closed)

Created:
8 years, 11 months ago by Evan Martin

Modified:
8 years, 11 months ago

Reviewers:
Nico

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Use a 'defines' block instead of adding -Dfoo to cflags. Should be equivalent, but simpler. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119087

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -10 lines)			Patch
	M	base/allocator/allocator.gyp	View		3 chunks	+7 lines, -5 lines	0 comments	Download
	M	build/common.gypi	View		3 chunks	+9 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/evan@chromium.org/9235021/1

8 years, 11 months ago (2012-01-25 16:23:11 UTC) #3

Change committed as 119087