Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: build/common.gypi

Issue 9235021: Use a 'defines' block instead of adding -Dfoo to cflags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/allocator/allocator.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 04344b642361586a9cfb7ee9a57d5c0b5bc863c1..7f8099acc73ee17f05dcc95c74495780bddc4f75 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1662,6 +1662,9 @@
}],
],
},
+ 'defines': [
+ '_FILE_OFFSET_BITS=64',
+ ],
'cflags': [
'<(werror)', # See note above about the werror variable.
'-pthread',
@@ -1674,7 +1677,6 @@
'-Wno-unused-parameter',
# Don't warn about the "struct foo f = {0};" initialization pattern.
'-Wno-missing-field-initializers',
- '-D_FILE_OFFSET_BITS=64',
# Don't export any symbols (for example, to plugins we dlopen()).
# Note: this is *required* to make some plugins work.
'-fvisibility=hidden',
@@ -1936,10 +1938,12 @@
'-march=armv5te',
'-mtune=xscale',
'-msoft-float',
- '-D__ARM_ARCH_5__',
- '-D__ARM_ARCH_5T__',
- '-D__ARM_ARCH_5E__',
- '-D__ARM_ARCH_5TE__',
+ ],
+ 'defines': [
+ '__ARM_ARCH_5__',
+ '__ARM_ARCH_5T__',
+ '__ARM_ARCH_5E__',
+ '__ARM_ARCH_5TE__',
],
}],
],
« no previous file with comments | « base/allocator/allocator.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698