Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: base/allocator/allocator.gyp

Issue 9235021: Use a 'defines' block instead of adding -Dfoo to cflags. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/common.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/allocator/allocator.gyp
diff --git a/base/allocator/allocator.gyp b/base/allocator/allocator.gyp
index d10fd49d547388807b60667ef55cd99edd0cfd93..ea5ff849cfb901cea54769b144040b31a0f2fbd2 100644
--- a/base/allocator/allocator.gyp
+++ b/base/allocator/allocator.gyp
@@ -367,8 +367,8 @@
# so only one of them should be used.
'<(tcmalloc_dir)/src/tcmalloc.cc',
],
- 'cflags': [
- '-DTCMALLOC_FOR_DEBUGALLOCATION',
+ 'defines': [
+ 'TCMALLOC_FOR_DEBUGALLOCATION',
],
}, { # linux_use_debugallocation != 1
'sources!': [
@@ -383,7 +383,9 @@
],
'cflags': [
'-finstrument-functions',
- '-DKEEP_SHADOW_STACKS',
+ ],
+ 'defines': [
+ 'KEEP_SHADOW_STACKS',
],
}],
[ 'linux_use_heapchecker==0', {
@@ -393,8 +395,8 @@
'<(tcmalloc_dir)/src/heap-checker.cc',
],
# Disable the heap checker in tcmalloc.
- 'cflags': [
- '-DNO_HEAP_CHECK',
+ 'defines': [
+ 'NO_HEAP_CHECK',
],
}],
],
« no previous file with comments | « no previous file | build/common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698