Acquire all layers when hiding window gets destroyed.

Acquire all layers when hiding window gets destroyed.
Add duration to show/hide animation (lock screen has longer animation)
Window can now specify in which visibility change phrase
it wants to animate (login screen and lock screen should animate only when hiding)

BUG=none
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119949

[Ben Goodger (Google), 2012-01-31 00:50:19]

http://codereview.chromium.org/9233044/diff/4005/ash/wm/window_animations.cc
File ash/wm/window_animations.cc (right):

http://codereview.chromium.org/9233044/diff/4005/ash/wm/window_animations.cc#...
ash/wm/window_animations.cc:118: DCHECK_EQ(0u, layers_.size());
or layers_.empty()

http://codereview.chromium.org/9233044/diff/4005/ash/wm/window_animations.cc#...
ash/wm/window_animations.cc:126: if (layer)
can this ever be NULL?

http://codereview.chromium.org/9233044/diff/4005/ash/wm/window_animations.h
File ash/wm/window_animations.h (right):

http://codereview.chromium.org/9233044/diff/4005/ash/wm/window_animations.h#n...
ash/wm/window_animations.h:30: // 0 is used as default.
ANIMATE_NONE = 0x0,
ANIMATE_SHOW = 0x1,
ANIMATE_HIDE = 0x2,
ANIMATE_BOTH = ANIMATE_SHOW | ANIMATE_HIDE

... just assume that _BOTH is the default.

http://codereview.chromium.org/9233044/diff/4005/ash/wm/window_animations.h#n...
ash/wm/window_animations.h:43: WindowVisibilityAnimationTransition phrase);
phase

http://codereview.chromium.org/9233044/diff/4005/ash/wm/window_animations.h#n...
ash/wm/window_animations.h:45: void ASH_EXPORT
SetWindowVisibilityAnimationDuration(
What do you use this for?

[oshima, 2012-01-31 01:52:32]

http://codereview.chromium.org/9233044/diff/4005/ash/wm/window_animations.cc
File ash/wm/window_animations.cc (right):

http://codereview.chromium.org/9233044/diff/4005/ash/wm/window_animations.cc#...
ash/wm/window_animations.cc:118: DCHECK_EQ(0u, layers_.size());
On 2012/01/31 00:50:19, Ben Goodger (Google) wrote:
> or layers_.empty()

Done.

http://codereview.chromium.org/9233044/diff/4005/ash/wm/window_animations.cc#...
ash/wm/window_animations.cc:126: if (layer)
On 2012/01/31 00:50:19, Ben Goodger (Google) wrote:
> can this ever be NULL?

Technically yes. (If someone called AcquireLayer on the same window). I can
change this to DCHECK(layer) if this should not happen.

http://codereview.chromium.org/9233044/diff/4005/ash/wm/window_animations.h
File ash/wm/window_animations.h (right):

http://codereview.chromium.org/9233044/diff/4005/ash/wm/window_animations.h#n...
ash/wm/window_animations.h:30: // 0 is used as default.
On 2012/01/31 00:50:19, Ben Goodger (Google) wrote:
> ANIMATE_NONE = 0x0,
> ANIMATE_SHOW = 0x1,
> ANIMATE_HIDE = 0x2,
> ANIMATE_BOTH = ANIMATE_SHOW | ANIMATE_HIDE
> 
> ... just assume that _BOTH is the default.

changed to 0x, but I can't use 0x for NONE because 0/NULL is default value of a
property.

http://codereview.chromium.org/9233044/diff/4005/ash/wm/window_animations.h#n...
ash/wm/window_animations.h:43: WindowVisibilityAnimationTransition phrase);
On 2012/01/31 00:50:19, Ben Goodger (Google) wrote:
> phase

chagned to "transition"

http://codereview.chromium.org/9233044/diff/4005/ash/wm/window_animations.h#n...
ash/wm/window_animations.h:45: void ASH_EXPORT
SetWindowVisibilityAnimationDuration(
On 2012/01/31 00:50:19, Ben Goodger (Google) wrote:
> What do you use this for?

to set the login screen's animation duration which is 700ms.

[Ben Goodger (Google), 2012-01-31 17:35:44]

LGTM. We should probably DCHECK in AcquireLayer that it is not called twice.

[oshima, 2012-01-31 17:48:30]

On 2012/01/31 17:35:44, Ben Goodger (Google) wrote:
> LGTM. We should probably DCHECK in AcquireLayer that it is not called twice.

done.