Issue 9214002: Dedupe codereview.settings parsing code. Add more testing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9214002: Dedupe codereview.settings parsing code. Add more testing. (Closed)

Created:
8 years, 11 months ago by M-A Ruel

Modified:
8 years, 11 months ago

Reviewers:
Nicolas Sylvain, nsylvain

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Dedupe codereview.settings parsing code. Add more testing. So any modification to the defaults is coded at only one place. TBR=nsylvain@chromium.org BUG=107838 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117853

Created: 8 years, 11 months ago

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -16 lines)
M	gcl.py	View	1 chunk	+2 lines, -9 lines	0 comments
M	gclient_utils.py	View	1 chunk	+12 lines, -0 lines	0 comments
M	git_cl.py	View	1 chunk	+1 line, -6 lines	0 comments
M	tests/gclient_utils_test.py	View	2 chunks	+17 lines, -1 line	0 comments

Total messages: 5 (0 generated)

M-A Ruel

TBR'ing since https://chromiumcodereview.appspot.com/9214004/ is dependent on this one.

8 years, 11 months ago (2012-01-16 14:45:57 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9214002/1

8 years, 11 months ago (2012-01-16 14:46:07 UTC) #3

lgtm