Dedupe codereview.settings parsing code. Add more testing.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld."""
 
 import logging
@@ skipping 699 matching lines @@
     if filename in os.listdir(cwd):
       if os.path.isfile(os.path.join(cwd, filename)):
         return open(os.path.join(cwd, filename))
     if cwd == root:
       break
     cwd = os.path.dirname(cwd)
 
 
 def LoadCodereviewSettingsFromFile(fileobj):
   """Parse a codereview.settings file and updates hooks."""
-  keyvals = {}
-  for line in fileobj.read().splitlines():
-    if not line or line.startswith("#"):
-      continue
-    k, v = line.split(": ", 1)
-    keyvals[k] = v
+  keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
 
   def SetProperty(name, setting, unset_error_ok=False):
     fullname = 'rietveld.' + name
     if setting in keyvals:
       RunGit(['config', fullname, keyvals[setting]])
     else:
       RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
 
   SetProperty('server', 'CODE_REVIEW_SERVER')
   # Only server setting is required. Other settings can be absent.
@@ skipping 695 matching lines @@
              'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
 
   # Not a known command. Default to help.
   GenUsage(parser, 'help')
   return CMDhelp(parser, argv)
 
 
 if __name__ == '__main__':
   fix_encoding.fix_encoding()
   sys.exit(main(sys.argv[1:]))