Dedupe codereview.settings parsing code. Add more testing.

gclient_utils.py

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic utils."""
 
 import errno
 import logging
 import os
 import Queue
@@ skipping 714 matching lines @@
       cmd = 'env ' + cmd
     try:
       # shell=True to allow the shell to handle all forms of quotes in
       # $EDITOR.
       subprocess2.check_call(cmd, shell=True)
     except subprocess2.CalledProcessError:
       return None
     return FileRead(filename)
   finally:
     os.remove(filename)
+
+
+def ParseCodereviewSettingsContent(content):
+  """Process a codereview.settings file properly."""
+  lines = (l for l in content.splitlines() if not l.strip().startswith("#"))
+  try:
+    keyvals = dict([x.strip() for x in l.split(':', 1)] for l in lines if l)
+  except ValueError:
+    raise Error(
+        'Failed to process settings, please fix. Content:\n\n%s' % content)
+  # TODO(maruel): Post-process
+  return keyvals