aura: No shadow for transparent window.

aura: No shadow for transparent window.
    
- Add a transparent flag to Window;
- Use the transparent in Window::Init to call Layer::SetFillsBoundsOpaquely;
- Update ShadowController to use SHADOW_TYPE_NONE for transparent window;
    
Side change:
- Make tooltip widget non-transparent as it needs the default shadow;
    
BUG=110916
TEST=Verify fix for issue 110916 and drop-n-drop works as before.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119184

[xiyuan, 2012-01-25 18:31:59]

Drag image widget probably should be a popup rather than a tooltip. It is
already transparent and always-on-top and should work properly as a popup.

The strange square in issue 110916 comes from shadow controller. Right now, we
are applying SHADOW_TYPE_RECTANGULAR to tooltip windows.

[Ben Goodger (Google), 2012-01-25 18:38:36]

My concern here is stacking. It seems like we need this item to be stacked
above menus. (for example when doing drag and drop in a menu)

-Ben

On Wed, Jan 25, 2012 at 10:31 AM, <xiyuan@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> Drag image widget probably should be a popup rather than a tooltip. It is
> already transparent and always-on-top and should work properly as a popup.
>
> The strange square in issue 110916 comes from shadow controller. Right
> now, we
> are applying SHADOW_TYPE_RECTANGULAR to tooltip windows.
>
> Description:
> aura: Use TYPE_POPUP for DragImageView
>
> BUG=110916
> TEST=Verify fix for issue 110916 and drop-n-drop works as before.
>
>
> Please review this at
http://codereview.chromium.**org/9169050/<http://codereview.chromium.org/9169...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ash/drag_drop/drag_image_view.**cc
>
>
> Index: ash/drag_drop/drag_image_view.**cc
> diff --git a/ash/drag_drop/drag_image_**view.cc
> b/ash/drag_drop/drag_image_**view.cc
> index 993d4b88a018ea80ed050930042a30**7cfe370127..**
> 744f53c3865c1fe99257b600796a28**7b01816142 100644
> --- a/ash/drag_drop/drag_image_**view.cc
> +++ b/ash/drag_drop/drag_image_**view.cc
> @@ -15,7 +15,7 @@ using views::Widget;
>  Widget* CreateDragWidget() {
>   Widget* drag_widget = new Widget;
>   Widget::InitParams params;
> -  params.type = Widget::InitParams::TYPE_**TOOLTIP;
> +  params.type = Widget::InitParams::TYPE_**POPUP;
>   params.keep_on_top = true;
>   params.accept_events = false;
>   params.ownership = Widget::InitParams::WIDGET_**OWNS_NATIVE_WIDGET;
>
>
>

[xiyuan, 2012-01-25 21:04:47]

Please take another look.

The CL is changed to fix the problem by applying a "no shadow for transparent
window" policy per discussion.

[Ben Goodger (Google), 2012-01-25 23:02:36]

lgtm

http://codereview.chromium.org/9169050/diff/3002/ash/wm/shadow_controller.cc
File ash/wm/shadow_controller.cc (right):

http://codereview.chromium.org/9169050/diff/3002/ash/wm/shadow_controller.cc#...
ash/wm/shadow_controller.cc:26: switch (window->type()) {
I think as a general rule transparent windows shouldn't have shadows... so
perhaps rather than putting the condition in each branch below you can just do a
test at the beginning and return early.

[xiyuan, 2012-01-25 23:33:13]

http://codereview.chromium.org/9169050/diff/3002/ash/wm/shadow_controller.cc
File ash/wm/shadow_controller.cc (right):

http://codereview.chromium.org/9169050/diff/3002/ash/wm/shadow_controller.cc#...
ash/wm/shadow_controller.cc:26: switch (window->type()) {
On 2012/01/25 23:02:36, Ben Goodger (Google) wrote:
> I think as a general rule transparent windows shouldn't have shadows... so
> perhaps rather than putting the condition in each branch below you can just do
a
> test at the beginning and return early.

Done.

[commit-bot: I haz the power, 2012-01-26 01:50:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/9169050/5002

[commit-bot: I haz the power, 2012-01-26 03:24:08]

Change committed as 119184