Detect sync server communication errors

chrome/browser/sync/sessions/sync_session.cc

Index: chrome/browser/sync/sessions/sync_session.cc
diff --git a/chrome/browser/sync/sessions/sync_session.cc b/chrome/browser/sync/sessions/sync_session.cc
index 064fef6744e9d753fbb4b2e58975646e16ab9190..df6733deef79ac031be5d70dc3c9f0b2ed700d1d 100644
--- a/chrome/browser/sync/sessions/sync_session.cc
+++ b/chrome/browser/sync/sessions/sync_session.cc
@@ -233,6 +233,26 @@ std::set<ModelSafeGroup>
   return enabled_groups_with_verified_updates;
 }
 
+namespace {
+// Return true if the command in question was attempted and did not complete
+// successfully.
+//
+bool IsError(SyncerError error) {
+  return error != UNSET && error != SYNCER_OK;
+}
+}  // namespace
+
+bool SyncSession::Succeeded() const {
+  bool download_updates_error =

[tim (not reviewing), 2012/01/10 17:17:34]

nit - these 3 bools could be const.

[rlarocque, 2012/01/10 20:40:56]

Done.

+      IsError(status_controller_->error().download_updates_result);
+  bool post_commit_error =
+      IsError(status_controller_->error().post_commit_result);
+  bool process_commit_response_error =
+      IsError(status_controller_->error().process_commit_response_result);
+  return !download_updates_error
+      && !post_commit_error
+      && !process_commit_response_error;
+}
 
 }  // namespace sessions
 }  // namespace browser_sync