Detect sync server communication errors

chrome/browser/sync/sessions/sync_session.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/sessions/sync_session.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "chrome/browser/sync/syncable/directory_manager.h"
@@ skipping 215 matching lines @@
     if (update_progress &&
         (update_progress->VerifiedUpdatesBegin() !=
          update_progress->VerifiedUpdatesEnd())) {
       enabled_groups_with_verified_updates.insert(*it);
     }
   }
 
   return enabled_groups_with_verified_updates;
 }
 
+namespace {
+// Return true if the command in question was attempted and did not complete
+// successfully.
+//
+bool IsError(SyncerError error) {
+  return error != UNSET && error != SYNCER_OK;
+}
+}  // namespace
+
+bool SyncSession::Succeeded() const {
+  bool download_updates_error =

[tim (not reviewing), 2012/01/10 17:17:34]

nit - these 3 bools could be const.

[rlarocque, 2012/01/10 20:40:56]

Done.

+      IsError(status_controller_->error().download_updates_result);
+  bool post_commit_error =
+      IsError(status_controller_->error().post_commit_result);
+  bool process_commit_response_error =
+      IsError(status_controller_->error().process_commit_response_result);
+  return !download_updates_error
+      && !post_commit_error
+      && !process_commit_response_error;
+}
 
 }  // namespace sessions
 }  // namespace browser_sync