Issue 9155010: Minor cleanups of numeric seeded hashing patch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9155010: Minor cleanups of numeric seeded hashing patch. (Closed)

Created:
8 years, 11 months ago by Erik Corry

Modified:
8 years, 11 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Minor cleanups of numeric seeded hashing patch. Committed: http://code.google.com/p/v8/source/detail?r=10367

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -49 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/heap.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/macro-assembler-mips.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/objects.cc	View	5 chunks	+9 lines, -9 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/profile-generator.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-hashing.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages