Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: src/objects.h

Issue 9155010: Minor cleanups of numeric seeded hashing patch. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/macro-assembler-mips.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2581 matching lines...) Expand 10 before | Expand all | Expand 10 after
2592 // The prefix size indicates an amount of memory in the 2592 // The prefix size indicates an amount of memory in the
2593 // beginning of the backing storage that can be used for non-element 2593 // beginning of the backing storage that can be used for non-element
2594 // information by subclasses. 2594 // information by subclasses.
2595 2595
2596 template<typename Key> 2596 template<typename Key>
2597 class BaseShape { 2597 class BaseShape {
2598 public: 2598 public:
2599 static const bool UsesSeed = false; 2599 static const bool UsesSeed = false;
2600 static uint32_t Hash(Key key) { return 0; } 2600 static uint32_t Hash(Key key) { return 0; }
2601 static uint32_t SeededHash(Key key, uint32_t seed) { 2601 static uint32_t SeededHash(Key key, uint32_t seed) {
2602 // Won't be called if UsesSeed isn't overridden by child class. 2602 ASSERT(UsesSeed);
2603 return Hash(key); 2603 return Hash(key);
2604 } 2604 }
2605 static uint32_t HashForObject(Key key, Object* object) { return 0; } 2605 static uint32_t HashForObject(Key key, Object* object) { return 0; }
2606 static uint32_t SeededHashForObject(Key key, uint32_t seed, Object* object) { 2606 static uint32_t SeededHashForObject(Key key, uint32_t seed, Object* object) {
2607 // Won't be called if UsesSeed isn't overridden by child class. 2607 // Won't be called if UsesSeed isn't overridden by child class.
2608 return HashForObject(key, object); 2608 return HashForObject(key, object);
2609 } 2609 }
2610 }; 2610 };
2611 2611
2612 template<typename Shape, typename Key> 2612 template<typename Shape, typename Key>
2613 class HashTable: public FixedArray { 2613 class HashTable: public FixedArray {
2614 public: 2614 public:
2615 // Wrapper methods 2615 // Wrapper methods
2616 inline uint32_t Hash(Key key) { 2616 inline uint32_t Hash(Key key) {
2617 if (Shape::UsesSeed) { 2617 if (Shape::UsesSeed) {
2618 return Shape::SeededHash(key, 2618 return Shape::SeededHash(key,
2619 GetHeap()->StringHashSeed()); 2619 GetHeap()->HashSeed());
2620 } else { 2620 } else {
2621 return Shape::Hash(key); 2621 return Shape::Hash(key);
2622 } 2622 }
2623 } 2623 }
2624 2624
2625 inline uint32_t HashForObject(Key key, Object* object) { 2625 inline uint32_t HashForObject(Key key, Object* object) {
2626 if (Shape::UsesSeed) { 2626 if (Shape::UsesSeed) {
2627 return Shape::SeededHashForObject(key, 2627 return Shape::SeededHashForObject(key,
2628 GetHeap()->StringHashSeed(), object); 2628 GetHeap()->HashSeed(), object);
2629 } else { 2629 } else {
2630 return Shape::HashForObject(key, object); 2630 return Shape::HashForObject(key, object);
2631 } 2631 }
2632 } 2632 }
2633 2633
2634 // Returns the number of elements in the hash table. 2634 // Returns the number of elements in the hash table.
2635 int NumberOfElements() { 2635 int NumberOfElements() {
2636 return Smi::cast(get(kNumberOfElementsIndex))->value(); 2636 return Smi::cast(get(kNumberOfElementsIndex))->value();
2637 } 2637 }
2638 2638
(...skipping 5484 matching lines...) Expand 10 before | Expand all | Expand 10 after
8123 } else { 8123 } else {
8124 value &= ~(1 << bit_position); 8124 value &= ~(1 << bit_position);
8125 } 8125 }
8126 return value; 8126 return value;
8127 } 8127 }
8128 }; 8128 };
8129 8129
8130 } } // namespace v8::internal 8130 } } // namespace v8::internal
8131 8131
8132 #endif // V8_OBJECTS_H_ 8132 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « src/mips/macro-assembler-mips.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698