Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2150)

Unified Diff: src/heap-profiler.h

Issue 9139018: Provide a way for iterating through all external strings referenced from the JS heap (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap-profiler.h
===================================================================
--- src/heap-profiler.h (revision 10391)
+++ src/heap-profiler.h (working copy)
@@ -73,6 +73,13 @@
return snapshots_->is_tracking_objects();
}
+ class ExternalResourceVisitor {
mnaganov (inactive) 2012/01/11 18:50:23 Do you really need this class? What's wrong with u
yurys 2012/01/11 19:50:13 Done. I thought we try to work only with internal
+ public:
+ virtual void VisitExternalString(String* string) = 0;
+ virtual ~ExternalResourceVisitor() {}
+ };
+ static void VisitExternalResources(ExternalResourceVisitor* visitor);
mnaganov (inactive) 2012/01/11 18:50:23 The same is for the implementation. Perhaps, put t
yurys 2012/01/11 19:50:13 Done.
+
private:
HeapProfiler();
~HeapProfiler();

Powered by Google App Engine
This is Rietveld 408576698