Chromium Code Reviews

Unified Diff: include/v8-profiler.h

Issue 9139018: Provide a way for iterating through all external strings referenced from the JS heap (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | src/api.cc » ('j') | src/heap-profiler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8-profiler.h
===================================================================
--- include/v8-profiler.h (revision 10391)
+++ include/v8-profiler.h (working copy)
@@ -434,6 +434,22 @@
* handle.
*/
static const uint16_t kPersistentHandleNoClassId = 0;
+
+
+ /**
+ * Interface for iterating though all external resource in the heap.
+ */
+ class ExternalResourceVisitor {
mnaganov (inactive) 2012/01/11 18:50:23 You need to put V8EXPORT before the class name.
yurys 2012/01/11 19:50:13 Done.
+ public:
+ virtual void VisitExternalString(Handle<String> string) {}
+ virtual ~ExternalResourceVisitor() {}
mnaganov (inactive) 2012/01/11 18:50:23 Destructor must be the first.
yurys 2012/01/11 19:50:13 Done.
+ };
+
+ /**
+ * Iterates through all external resources referenced from current isolate
+ * heap.
+ */
+ static void VisitExternalResources(ExternalResourceVisitor* visitor);
mnaganov (inactive) 2012/01/11 18:50:23 I'm not sure HeapProfiler class is a good place fo
yurys 2012/01/11 19:50:13 Since it is used to analyze heap I decided to put
};
« no previous file with comments | « no previous file | src/api.cc » ('j') | src/heap-profiler.h » ('J')

Powered by Google App Engine