Provide a way for iterating through all external strings referenced from the JS heap

src/heap-profiler.h

 // Copyright 2009-2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 55 matching lines @@
 
   void DefineWrapperClass(
       uint16_t class_id, v8::HeapProfiler::WrapperInfoCallback callback);
 
   v8::RetainedObjectInfo* ExecuteWrapperClassCallback(uint16_t class_id,
                                                       Object** wrapper);
   INLINE(bool is_profiling()) {
     return snapshots_->is_tracking_objects();
   }
 
+  class ExternalResourceVisitor {

[mnaganov (inactive), 2012/01/11 18:50:23]

Do you really need this class? What's wrong with using the one you have defined
in the API?

[yurys, 2012/01/11 19:50:13]

Done. I thought we try to work only with internal classes in the code under src/

+   public:
+    virtual void VisitExternalString(String* string) = 0;
+    virtual ~ExternalResourceVisitor() {}
+  };
+  static void VisitExternalResources(ExternalResourceVisitor* visitor);

[mnaganov (inactive), 2012/01/11 18:50:23]

The same is for the implementation. Perhaps, put this into heap.cc?

[yurys, 2012/01/11 19:50:13]

Done.

+
  private:
   HeapProfiler();
   ~HeapProfiler();
   HeapSnapshot* TakeSnapshotImpl(const char* name,
                                  int type,
                                  v8::ActivityControl* control);
   HeapSnapshot* TakeSnapshotImpl(String* name,
                                  int type,
                                  v8::ActivityControl* control);
   void ResetSnapshots();
 
   HeapSnapshotsCollection* snapshots_;
   unsigned next_snapshot_uid_;
   List<v8::HeapProfiler::WrapperInfoCallback> wrapper_callbacks_;
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_HEAP_PROFILER_H_