Provide a way for iterating through all external strings referenced from the JS heap

include/v8-profiler.h

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 416 matching lines @@
   static void DefineWrapperClass(
       uint16_t class_id,
       WrapperInfoCallback callback);
 
   /**
    * Default value of persistent handle class ID. Must not be used to
    * define a class. Can be used to reset a class of a persistent
    * handle.
    */
   static const uint16_t kPersistentHandleNoClassId = 0;
+
+
+  /**
+   * Interface for iterating though all external resource in the heap.
+   */
+  class ExternalResourceVisitor {

[mnaganov (inactive), 2012/01/11 18:50:23]

You need to put V8EXPORT before the class name.

[yurys, 2012/01/11 19:50:13]

Done.

+   public:
+    virtual void VisitExternalString(Handle<String> string) {}
+    virtual ~ExternalResourceVisitor() {}

[mnaganov (inactive), 2012/01/11 18:50:23]

Destructor must be the first.

[yurys, 2012/01/11 19:50:13]

Done.

+  };
+
+  /**
+   * Iterates through all external resources referenced from current isolate
+   * heap.
+   */
+  static void VisitExternalResources(ExternalResourceVisitor* visitor);

[mnaganov (inactive), 2012/01/11 18:50:23]

I'm not sure HeapProfiler class is a good place for this method -- it doesn't
relate to HeapSnapshots at all, as it iterates live heap. Why not to add it into
the V8 interface class?

[yurys, 2012/01/11 19:50:13]

Since it is used to analyze heap I decided to put it into the heap profiler. I
don't mind moving it into V8 class if you feel it should rather go there.

 };
 
 
 /**
  * Interface for providing information about embedder's objects
  * held by global handles. This information is reported in two ways:
  *
  *  1. When calling AddObjectGroup, an embedder may pass
  *     RetainedObjectInfo instance describing the group.  To collect
  *     this information while taking a heap snapshot, V8 calls GC
@@ skipping 53 matching lines @@
 };
 
 
 }  // namespace v8
 
 
 #undef V8EXPORT
 
 
 #endif  // V8_V8_PROFILER_H_