Add parsing of "Failing tests:" from gtest output.

Add parsing of "Failing tests:" from gtest output.

This catches failing tests that e.g. crash after the OK line.

For example, PrerenderBrowserTest.PrerenderHTML5VideoJs failure from:

http://build.chromium.org/p/chromium/builders/Mac10.5%20Tests%20%283%29/builds/8107/steps/browser_tests/logs/stdio/text

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116683

[M-A Ruel, 2012-01-06 17:07:35]

would you mind updating unittests/gtest_command_unittest.py at the same time?

It's currently broken though so it's not run automatically.

Once it's fixed, it should be renamed to gtest_command_test.py so it's picked up
by PRESUBMIT.py.

http://codereview.chromium.org/9134001/diff/3001/scripts/master/log_parser/gt...
File scripts/master/log_parser/gtest_command.py (right):

http://codereview.chromium.org/9134001/diff/3001/scripts/master/log_parser/gt...
scripts/master/log_parser/gtest_command.py:303: elif line.find('Failing tests:')
!= -1:
elif 'Failing tests:' in line:

[Alexei Svitkine (slow), 2012-01-06 18:08:02]

I've added a test. All the sharding tests are failing, and I don't have enough
context to fix them. I've put them in DISABLED_testLogLineObserverSharding().

http://codereview.chromium.org/9134001/diff/3001/scripts/master/log_parser/gt...
File scripts/master/log_parser/gtest_command.py (right):

http://codereview.chromium.org/9134001/diff/3001/scripts/master/log_parser/gt...
scripts/master/log_parser/gtest_command.py:303: elif line.find('Failing tests:')
!= -1:
On 2012/01/06 17:07:36, Marc-Antoine Ruel wrote:
> elif 'Failing tests:' in line:

Changed to startswith(), which is more precise.

[M-A Ruel, 2012-01-06 18:11:26]

lgtm

[commit-bot: I haz the power, 2012-01-06 18:13:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/9134001/10002

[commit-bot: I haz the power, 2012-01-06 18:17:59]

Change committed as 116683