Add parsing of "Failing tests:" from gtest output.

scripts/master/log_parser/gtest_command.py

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A buildbot command for running and interpreting GTest tests."""
 
 import re
 from buildbot.steps import shell
 from buildbot.status import builder
 from buildbot.process import buildstep
 
 class TestObserver(buildstep.LogLineObserver):
   """This class knows how to understand GTest test output."""
   # TestAbbrFromTestID needs to be a member function.
   # pylint: disable=R0201
 
   def __init__(self):
     buildstep.LogLineObserver.__init__(self)
 
     # State tracking for log parsing
     self._current_test = ''
     self._failure_description = []
     self._current_suppression_hash = ''
     self._current_suppression = []
+    self._parsing_failures = False
 
     # Line number currently being processed.
     self._line_number = 0
 
     # List of parsing errors, as human-readable strings.
     self.internal_error_lines = []
 
     # Tests are stored here as 'test.name': (status, [description]).
     # The status should be one of ('started', 'OK', 'failed', 'timeout',
     # 'warning'). Warning indicates that a test did not pass when run in
     # parallel with other tests but passed when run alone. The description is
     # a list of lines detailing the test's error, as reported in the log.
     self._test_status = {}
 
     # Suppressions are stored here as 'hash': [suppression].
     self._suppressions = {}
 
     # This may be either text or a number. It will be used in the phrase
     # '%s disabled' or '%s flaky' on the waterfall display.
     self.disabled_tests = 0
     self.flaky_tests = 0
 
     # Regular expressions for parsing GTest logs. Test names look like
     #   SomeTestCase.SomeTest
     #   SomeName/SomeTestCase.SomeTest/1
     # This regexp also matches SomeName.SomeTest/1, which should be harmless.
     test_name_regexp = r'((\w+/)?\w+\.\w+(/\d+)?)'
 
+    self._test_name    = re.compile(test_name_regexp)
     self._test_start   = re.compile('\[\s+RUN\s+\] ' + test_name_regexp)
     self._test_ok      = re.compile('\[\s+OK\s+\] ' + test_name_regexp)
     self._test_fail    = re.compile('\[\s+FAILED\s+\] ' + test_name_regexp)
     self._test_timeout = re.compile(
         'Test timeout \([0-9]+ ms\) exceeded for ' + test_name_regexp)
     self._disabled     = re.compile('  YOU HAVE (\d+) DISABLED TEST')
     self._flaky        = re.compile('  YOU HAVE (\d+) FLAKY TEST')
 
     self._suppression_start = re.compile(
         'Suppression \(error hash=#([0-9A-F]+)#\):')
@@ skipping 216 matching lines @@
     if self._current_suppression_hash:
       self._current_suppression.append(line)
       return
 
     # Random line: if we're in a test, collect it for the failure description.
     # Tests may run simultaneously, so this might be off, but it's worth a try.
     # This also won't work if a test times out before it begins running.
     if self._current_test:
       self._failure_description.append(line)
 
+    # Parse the "Failing tests:" list at the end of the output, and add any
+    # additional failed tests to the list. For example, this includes tests
+    # that crash after the OK line.
+    if self._parsing_failures:
+      results = self._test_name.search(line)
+      if results:
+        test_name = results.group(1)
+        if self._StatusOfTest(test_name) == 'OK':
+          self._test_status[test_name] = (
+              'failed', ['Unknown error, see stdio log.'])
+      else:
+        self._parsing_failures = False
+    elif line.find('Failing tests:') != -1:

[M-A Ruel, 2012/01/06 17:07:36]

elif 'Failing tests:' in line:

[Alexei Svitkine (slow), 2012/01/06 18:08:03]

Changed to startswith(), which is more precise.

+      self._parsing_failures = True
 
 class GTestCommand(shell.ShellCommand):
   """Buildbot command that knows how to display GTest output."""
   # TestAbbrFromTestID needs to be a member function.
   # pylint: disable=R0201
 
   _GTEST_DASHBOARD_BASE = ("http://test-results.appspot.com"
     "/dashboards/flakiness_dashboard.html")
 
   def __init__(self, **kwargs):
@@ skipping 72 matching lines @@
       self.addCompleteLog(suppression_hash,
                           '\n'.join(observer.Suppression(suppression_hash)))
 
 
 class GTestFullCommand(GTestCommand):
   def TestAbbrFromTestID(self, testid):
     """
     Return the full TestCase.TestName ID.
     """
     return testid