Issue 9124012: - Pass in the isolate parameter when creating handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9124012: - Pass in the isolate parameter when creating handles. (Closed)

Created:
8 years, 11 months ago by siva

Modified:
8 years, 11 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

- Pass in the isolate parameter when creating handles. - Store the current isolate pointer in the snapshot reader object and use it instead of calling Isolate::Current() during the deserializing process. Committed: https://code.google.com/p/dart/source/detail?r=3160

Patch Set 1 #

Patch Set 2 : '' #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -107 lines)			Patch
M	vm/dart.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	vm/dart_api_impl.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	vm/handles.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	vm/handles.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	vm/handles_impl.h	View		2 chunks	+2 lines, -8 lines	0 comments	Download
M	vm/isolate.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	vm/object.h	View	1	4 chunks	+42 lines, -21 lines	0 comments	Download
M	vm/object.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	vm/raw_object_snapshot.cc	View		24 chunks	+37 lines, -25 lines	0 comments	Download
M	vm/snapshot.h	View		3 chunks	+6 lines, -9 lines	0 comments	Download
M	vm/snapshot.cc	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	vm/snapshot_test.cc	View		10 chunks	+10 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM -ip

Expand Messages | Collapse Messages