Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1242)

Unified Diff: vm/handles_impl.h

Issue 9124012: - Pass in the isolate parameter when creating handles. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/handles.cc ('k') | vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/handles_impl.h
===================================================================
--- vm/handles_impl.h (revision 3046)
+++ vm/handles_impl.h (working copy)
@@ -57,10 +57,7 @@
template <int kHandleSizeInWords, int kHandlesPerChunk, int kOffsetOfRawPtr>
uword Handles<kHandleSizeInWords,
kHandlesPerChunk,
- kOffsetOfRawPtr>::AllocateHandle() {
- // TODO(5411412): Accessing the current isolate is a performance problem,
- // consider passing it down as a parameter.
- Isolate* isolate = Isolate::Current();
+ kOffsetOfRawPtr>::AllocateHandle(Isolate* isolate) {
ASSERT(isolate != NULL);
ASSERT(isolate->current_zone() != NULL);
ASSERT(isolate->top_handle_scope() != NULL);
@@ -78,10 +75,7 @@
template <int kHandleSizeInWords, int kHandlesPerChunk, int kOffsetOfRawPtr>
uword Handles<kHandleSizeInWords,
kHandlesPerChunk,
- kOffsetOfRawPtr>::AllocateZoneHandle() {
- // TODO(5411412): Accessing the current isolate is a performance problem,
- // consider passing it down as a parameter.
- Isolate* isolate = Isolate::Current();
+ kOffsetOfRawPtr>::AllocateZoneHandle(Isolate* isolate) {
ASSERT(isolate != NULL);
ASSERT(isolate->current_zone() != NULL);
ASSERT(isolate->no_handle_scope_depth() == 0);
« no previous file with comments | « vm/handles.cc ('k') | vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698