Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: vm/snapshot_test.cc

Issue 9124012: - Pass in the isolate parameter when creating handles. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/snapshot.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/snapshot_test.cc
===================================================================
--- vm/snapshot_test.cc (revision 3046)
+++ vm/snapshot_test.cc (working copy)
@@ -53,8 +53,7 @@
const Snapshot* snapshot = Snapshot::SetupFromBuffer(buffer);
// Read object back from the snapshot.
- Isolate* isolate= Isolate::Current();
- SnapshotReader reader(snapshot, isolate->heap(), isolate->object_store());
+ SnapshotReader reader(snapshot, Isolate::Current());
const Object& serialized_object = Object::Handle(reader.ReadObject());
EXPECT(Equals(null_object, serialized_object));
}
@@ -72,8 +71,7 @@
const Snapshot* snapshot = Snapshot::SetupFromBuffer(buffer);
// Read object back from the snapshot.
- Isolate* isolate= Isolate::Current();
- SnapshotReader reader(snapshot, isolate->heap(), isolate->object_store());
+ SnapshotReader reader(snapshot, Isolate::Current());
const Object& serialized_object = Object::Handle(reader.ReadObject());
EXPECT(Equals(smi, serialized_object));
}
@@ -91,8 +89,7 @@
const Snapshot* snapshot = Snapshot::SetupFromBuffer(buffer);
// Read object back from the snapshot.
- Isolate* isolate= Isolate::Current();
- SnapshotReader reader(snapshot, isolate->heap(), isolate->object_store());
+ SnapshotReader reader(snapshot, Isolate::Current());
const Object& serialized_object = Object::Handle(reader.ReadObject());
EXPECT(Equals(smi, serialized_object));
}
@@ -110,8 +107,7 @@
const Snapshot* snapshot = Snapshot::SetupFromBuffer(buffer);
// Read object back from the snapshot.
- Isolate* isolate= Isolate::Current();
- SnapshotReader reader(snapshot, isolate->heap(), isolate->object_store());
+ SnapshotReader reader(snapshot, Isolate::Current());
const Object& serialized_object = Object::Handle(reader.ReadObject());
EXPECT(Equals(dbl, serialized_object));
}
@@ -131,8 +127,7 @@
const Snapshot* snapshot = Snapshot::SetupFromBuffer(buffer);
// Read object back from the snapshot.
- Isolate* isolate= Isolate::Current();
- SnapshotReader reader(snapshot, isolate->heap(), isolate->object_store());
+ SnapshotReader reader(snapshot, Isolate::Current());
EXPECT(Bool::True() == reader.ReadObject());
EXPECT(Bool::False() == reader.ReadObject());
}
@@ -150,8 +145,7 @@
const Snapshot* snapshot = Snapshot::SetupFromBuffer(buffer);
// Read object back from the snapshot.
- Isolate* isolate= Isolate::Current();
- SnapshotReader reader(snapshot, isolate->heap(), isolate->object_store());
+ SnapshotReader reader(snapshot, Isolate::Current());
Bigint& obj = Bigint::Handle();
obj ^= reader.ReadObject();
OS::Print("%lld", BigintOperations::ToInt64(obj));
@@ -188,8 +182,7 @@
const Snapshot* snapshot = Snapshot::SetupFromBuffer(buffer);
// Read object back from the snapshot.
- Isolate* isolate= Isolate::Current();
- SnapshotReader reader(snapshot, isolate->heap(), isolate->object_store());
+ SnapshotReader reader(snapshot, Isolate::Current());
EXPECT(Object::class_class() == reader.ReadObject());
EXPECT(Object::null_class() == reader.ReadObject());
EXPECT(Object::type_class() == reader.ReadObject());
@@ -224,8 +217,7 @@
const Snapshot* snapshot = Snapshot::SetupFromBuffer(buffer);
// Read object back from the snapshot.
- Isolate* isolate= Isolate::Current();
- SnapshotReader reader(snapshot, isolate->heap(), isolate->object_store());
+ SnapshotReader reader(snapshot, Isolate::Current());
String& serialized_str = String::Handle();
serialized_str ^= reader.ReadObject();
EXPECT(str.Equals(serialized_str));
@@ -250,8 +242,7 @@
const Snapshot* snapshot = Snapshot::SetupFromBuffer(buffer);
// Read object back from the snapshot.
- Isolate* isolate= Isolate::Current();
- SnapshotReader reader(snapshot, isolate->heap(), isolate->object_store());
+ SnapshotReader reader(snapshot, Isolate::Current());
Array& serialized_array = Array::Handle();
serialized_array ^= reader.ReadObject();
EXPECT(array.Equals(serialized_array));
@@ -283,8 +274,7 @@
const Snapshot* snapshot = Snapshot::SetupFromBuffer(buffer);
// Read object back from the snapshot.
- Isolate* isolate= Isolate::Current();
- SnapshotReader reader(snapshot, isolate->heap(), isolate->object_store());
+ SnapshotReader reader(snapshot, Isolate::Current());
Script& serialized_script = Script::Handle();
serialized_script ^= reader.ReadObject();
« no previous file with comments | « vm/snapshot.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698