Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 9113022: Adds PriorityQueue and PrioritizedDispatcher. (Closed)

Created:
8 years, 11 months ago by szym
Modified:
8 years, 11 months ago
Reviewers:
cbentzel, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Adds PriorityQueue and PrioritizedDispatcher. This will be used in HostResolverImpl to dispatch Jobs. BUG=109426 TEST=./net_unittests --gtest_filter=PriorityQueue*:PrioritizedDispatcher* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116736

Patch Set 1 : . #

Total comments: 6

Patch Set 2 : Applied review. #

Total comments: 6

Patch Set 3 : Moved typedef for List up front to let Pointer access it on mac.' #

Patch Set 4 : Applied review. #

Patch Set 5 : Removed changes to net/dns/ that don't belong to this CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+848 lines, -0 lines) Patch
A net/base/prioritized_dispatcher.h View 1 2 3 1 chunk +115 lines, -0 lines 0 comments Download
A net/base/prioritized_dispatcher.cc View 1 2 3 1 chunk +103 lines, -0 lines 0 comments Download
A net/base/prioritized_dispatcher_unittest.cc View 1 chunk +279 lines, -0 lines 0 comments Download
A net/base/priority_queue.h View 1 2 3 1 chunk +214 lines, -0 lines 0 comments Download
A net/base/priority_queue_unittest.cc View 1 2 3 1 chunk +132 lines, -0 lines 0 comments Download
M net/net.gyp View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
szym
Split this off from http://codereview.chromium.org/8965025/ I'll see if moving the Add/Cancel/OnJobFinished interface into Job works ...
8 years, 11 months ago (2012-01-05 21:29:38 UTC) #1
cbentzel
LGTM Please enter a bug for this, if only for tracking in the future. Also, ...
8 years, 11 months ago (2012-01-06 16:03:05 UTC) #2
szym
http://codereview.chromium.org/9113022/diff/8/net/base/prioritized_dispatcher.h File net/base/prioritized_dispatcher.h (right): http://codereview.chromium.org/9113022/diff/8/net/base/prioritized_dispatcher.h#newcode23 net/base/prioritized_dispatcher.h:23: // However, this class is NOT thread-safe. On 2012/01/06 ...
8 years, 11 months ago (2012-01-06 17:52:30 UTC) #3
mmenke
http://codereview.chromium.org/9113022/diff/11002/net/base/prioritized_dispatcher.cc File net/base/prioritized_dispatcher.cc (right): http://codereview.chromium.org/9113022/diff/11002/net/base/prioritized_dispatcher.cc#newcode1 net/base/prioritized_dispatcher.cc:1: // Copyright (c) 2011 The Chromium Authors. All rights ...
8 years, 11 months ago (2012-01-06 17:54:36 UTC) #4
szym
http://codereview.chromium.org/9113022/diff/11002/net/base/prioritized_dispatcher.h File net/base/prioritized_dispatcher.h (right): http://codereview.chromium.org/9113022/diff/11002/net/base/prioritized_dispatcher.h#newcode109 net/base/prioritized_dispatcher.h:109: size_t max_queued_jobs_; On 2012/01/06 17:54:37, Matt Menke wrote: > ...
8 years, 11 months ago (2012-01-06 17:56:42 UTC) #5
mmenke
No problem. With that fixed, LGTM. On 2012/01/06 17:56:42, szym wrote: > http://codereview.chromium.org/9113022/diff/11002/net/base/prioritized_dispatcher.h > File ...
8 years, 11 months ago (2012-01-06 17:58:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/9113022/20001
8 years, 11 months ago (2012-01-06 19:04:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/9113022/20001
8 years, 11 months ago (2012-01-06 19:45:23 UTC) #8
commit-bot: I haz the power
8 years, 11 months ago (2012-01-06 21:03:58 UTC) #9
Change committed as 116736

Powered by Google App Engine
This is Rietveld 408576698