Issue 9108024: Cleanup parameter passing issues in content/browser/download

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9108024: Cleanup parameter passing issues in content/browser/download (Closed)

Created:
8 years, 11 months ago by asanka

Modified:
8 years, 11 months ago

Reviewers:
Randy Smith (Not in Mondays), ahendrickson

CC:
chromium-reviews, jam, dcheng, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cleanup parameter passing issues in content/browser/download CID=102857, 102858 BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116734

Patch Set 1 #

Patch Set 2 : Remove fix for CID 102890 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -10 lines)			Patch
M	content/browser/download/download_manager_impl.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/download/download_manager_impl.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/download/mock_download_manager.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/download/mock_download_manager.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/public/browser/download_manager.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Randy Smith (Not in Mondays)

LGTM, but I'd like to give Andy a chance to comment, as it's really his ...

8 years, 11 months ago (2012-01-06 18:50:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/9108024/4001

8 years, 11 months ago (2012-01-06 19:48:30 UTC) #4

Change committed as 116734

Expand Messages | Collapse Messages