Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: content/browser/download/download_manager_impl.cc

Issue 9108024: Cleanup parameter passing issues in content/browser/download (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove fix for CID 102890 Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/download_manager_impl.h ('k') | content/browser/download/mock_download_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_manager_impl.cc
diff --git a/content/browser/download/download_manager_impl.cc b/content/browser/download/download_manager_impl.cc
index cb25d5fa8c35cce599c4de38af4c884a409ab536..5a7d97c29f02ad443833c1bb85a7a9151f2774bf 100644
--- a/content/browser/download/download_manager_impl.cc
+++ b/content/browser/download/download_manager_impl.cc
@@ -424,7 +424,7 @@ void DownloadManagerImpl::ContinueDownloadWithPath(
void DownloadManagerImpl::UpdateDownload(int32 download_id,
int64 bytes_so_far,
int64 bytes_per_sec,
- std::string hash_state) {
+ const std::string& hash_state) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DownloadMap::iterator it = active_downloads_.find(download_id);
if (it != active_downloads_.end()) {
@@ -623,7 +623,7 @@ void DownloadManagerImpl::DownloadCancelled(DownloadItem* download) {
void DownloadManagerImpl::OnDownloadInterrupted(int32 download_id,
int64 size,
- std::string hash_state,
+ const std::string& hash_state,
InterruptReason reason) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
« no previous file with comments | « content/browser/download/download_manager_impl.h ('k') | content/browser/download/mock_download_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698