content/browser/download/download_manager_impl.h - Issue 9108024: Cleanup parameter passing issues in content/browser/download

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_manager_impl.h

Issue 9108024: Cleanup parameter passing issues in content/browser/download (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove fix for CID 102890 Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_manager_impl.h

diff --git a/content/browser/download/download_manager_impl.h b/content/browser/download/download_manager_impl.h

index 6966fa334f126eaa9cf4283e6f4faa2ae2495120..8a3c96ba78c61bc6edd8d67ec824b09b471313e9 100644

--- a/content/browser/download/download_manager_impl.h

+++ b/content/browser/download/download_manager_impl.h

@@ -47,13 +47,13 @@ class CONTENT_EXPORT DownloadManagerImpl

virtual void UpdateDownload(int32 download_id,

int64 bytes_so_far,

int64 bytes_per_sec,

- std::string hash_state) OVERRIDE;

+ const std::string& hash_state) OVERRIDE;

virtual void OnResponseCompleted(int32 download_id, int64 size,

const std::string& hash) OVERRIDE;

virtual void CancelDownload(int32 download_id) OVERRIDE;

virtual void OnDownloadInterrupted(int32 download_id,

int64 size,

- std::string hash_state,

+ const std::string& hash_state,

InterruptReason reason) OVERRIDE;

virtual void OnDownloadRenamedToFinalName(int download_id,

const FilePath& full_path,

« no previous file with comments | « no previous file | content/browser/download/download_manager_impl.cc » ('j') | no next file with comments »