Move the tracked completion callback code into shared impl.

Move the tracked completion callback code into shared impl.

This keeps the original which is still used by all existing callers. The new
one exists in parallel through the magic of namespaces. I'll convert the
existing callers over in a subsequent pass.

I split it out into separate files: tracked_callback and callback_tracker. I
also merged the old TrackedCallback and TrackedCompletionCallback since we
never have any callbascks that aren't completion callbacks.

BUG=74062
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115982

[viettrungluu, 2011-12-29 03:45:27]

LGTM w/nits.

http://codereview.chromium.org/9006055/diff/4007/ppapi/proxy/plugin_globals.cc
File ppapi/proxy/plugin_globals.cc (right):

http://codereview.chromium.org/9006055/diff/4007/ppapi/proxy/plugin_globals.c...
ppapi/proxy/plugin_globals.cc:20: callback_tracker_ = new CallbackTracker;
Why don't you initialize this in the initializer list?

http://codereview.chromium.org/9006055/diff/4007/ppapi/proxy/plugin_globals.c...
ppapi/proxy/plugin_globals.cc:37: PP_Instance /* instance */) {
I thought we weren't in the habit of commenting out unused params.

http://codereview.chromium.org/9006055/diff/4007/ppapi/shared_impl/test_globa...
File ppapi/shared_impl/test_globals.cc (right):

http://codereview.chromium.org/9006055/diff/4007/ppapi/shared_impl/test_globa...
ppapi/shared_impl/test_globals.cc:10: callback_tracker_ = new CallbackTracker;
-> initializer list?

http://codereview.chromium.org/9006055/diff/4007/ppapi/shared_impl/test_globa...
ppapi/shared_impl/test_globals.cc:25: PP_Instance /* instance */) {
...

http://codereview.chromium.org/9006055/diff/4007/ppapi/shared_impl/tracked_ca...
File ppapi/shared_impl/tracked_callback.cc (right):

http://codereview.chromium.org/9006055/diff/4007/ppapi/shared_impl/tracked_ca...
ppapi/shared_impl/tracked_callback.cc:7: #include <algorithm>
Self-nit #2: I don't think this is actually needed.

http://codereview.chromium.org/9006055/diff/4007/ppapi/shared_impl/tracked_ca...
File ppapi/shared_impl/tracked_callback.h (right):

http://codereview.chromium.org/9006055/diff/4007/ppapi/shared_impl/tracked_ca...
ppapi/shared_impl/tracked_callback.h:101:
DISALLOW_COPY_AND_ASSIGN(TrackedCallback);
Self nit: I suppose this should've been DISALLOW_IMPLICIT_CONSTRUCTORS

http://codereview.chromium.org/9006055/diff/4007/ppapi/shared_impl/tracked_ca...
File ppapi/shared_impl/tracked_callback_unittest.cc (right):

http://codereview.chromium.org/9006055/diff/4007/ppapi/shared_impl/tracked_ca...
ppapi/shared_impl/tracked_callback_unittest.cc:15: #include
"ppapi/shared_impl/test_globals.h"
nit: alphabetical order