Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: ppapi/proxy/plugin_globals.cc

Issue 9006055: Move the tracked completion callback code into shared impl. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/plugin_globals.cc
===================================================================
--- ppapi/proxy/plugin_globals.cc (revision 115831)
+++ ppapi/proxy/plugin_globals.cc (working copy)
@@ -16,6 +16,8 @@
plugin_proxy_delegate_(NULL) {
DCHECK(!plugin_globals_);
plugin_globals_ = this;
+
+ callback_tracker_ = new CallbackTracker;
viettrungluu 2011/12/29 03:45:27 Why don't you initialize this in the initializer l
}
PluginGlobals::~PluginGlobals() {
@@ -31,6 +33,13 @@
return &plugin_var_tracker_;
}
+CallbackTracker* PluginGlobals::GetCallbackTrackerForInstance(
+ PP_Instance /* instance */) {
viettrungluu 2011/12/29 03:45:27 I thought we weren't in the habit of commenting ou
+ // In the plugin process, the callback tracker is always the same, regardless
+ // of the instance.
+ return callback_tracker_.get();
+}
+
FunctionGroupBase* PluginGlobals::GetFunctionAPI(PP_Instance inst, ApiID id) {
PluginDispatcher* dispatcher = PluginDispatcher::GetForInstance(inst);
if (dispatcher)

Powered by Google App Engine
This is Rietveld 408576698