Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: webkit/plugins/ppapi/plugin_module.cc

Issue 9006055: Move the tracked completion callback code into shared impl. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/ppapi/plugin_module.cc
===================================================================
--- webkit/plugins/ppapi/plugin_module.cc (revision 115831)
+++ webkit/plugins/ppapi/plugin_module.cc (working copy)
@@ -84,6 +84,7 @@
#include "ppapi/c/trusted/ppb_graphics_3d_trusted.h"
#include "ppapi/c/trusted/ppb_image_data_trusted.h"
#include "ppapi/c/trusted/ppb_url_loader_trusted.h"
+#include "ppapi/shared_impl/callback_tracker.h"
#include "ppapi/shared_impl/ppb_input_event_shared.h"
#include "ppapi/shared_impl/ppb_opengles2_shared.h"
#include "ppapi/shared_impl/ppb_var_shared.h"
@@ -415,7 +416,8 @@
const FilePath& path,
PluginDelegate::ModuleLifetime* lifetime_delegate)
: lifetime_delegate_(lifetime_delegate),
- callback_tracker_(new CallbackTracker),
+ old_callback_tracker_(new CallbackTracker),
+ callback_tracker_(new ::ppapi::CallbackTracker),
is_in_destructor_(false),
is_crashed_(false),
broker_(NULL),
@@ -445,6 +447,7 @@
GetLivePluginSet()->erase(this);
+ old_callback_tracker_->AbortAll();
callback_tracker_->AbortAll();
if (entry_points_.shutdown_module)
@@ -550,6 +553,10 @@
}
scoped_refptr<CallbackTracker> PluginModule::GetCallbackTracker() {
+ return old_callback_tracker_;
+}
+
+scoped_refptr< ::ppapi::CallbackTracker> PluginModule::GetNewCallbackTracker() {
return callback_tracker_;
}
« ppapi/shared_impl/tracked_callback_unittest.cc ('K') | « webkit/plugins/ppapi/plugin_module.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698