Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8983012: Get rid of content::NavigationController in cc file and use "using" instead. (Closed)

Created:
8 years, 11 months ago by jam
Modified:
8 years, 11 months ago
Reviewers:
CC:
chromium-reviews, nkostylev+watch_chromium.org, tburkard+watch_chromium.org, kkania, mihaip+watch_chromium.org, ajwong+watch_chromium.org, stevenjb+watch_chromium.org, ncarter (slow), jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, tim (not reviewing), jstritar+watch_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, Raghu Simha, cbentzel+watch_chromium.org, dpranke-watch+content_chromium.org, akalin, Aaron Boodman, dominich+watch_chromium.org, robertshield, mmenke, rdsmith+dwatch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Get rid of content::NavigationController in cc file and use "using" instead. BUG=98716 TBR=joi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116328

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+470 lines, -438 lines) Patch
M chrome/browser/alternate_nav_url_fetcher.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 10 chunks +13 lines, -14 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 14 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/automation/automation_provider_win.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/automation/automation_tab_tracker.cc View 3 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 37 chunks +37 lines, -45 lines 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/boot_times_loader.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/crash_recovery_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/debugger/devtools_sanity_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/download/download_request_limiter.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_browser_event_router.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_browsertests_misc.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_navigation_observer.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/isolated_app_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/external_tab_container_win.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.cc View 5 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/google/google_url_tracker.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/history/top_sites.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/infobars/infobar_tab_helper.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/instant/instant_loader.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/omnibox_search_hint.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_preview_message_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/repost_form_warning_controller.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 13 chunks +24 lines, -26 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sidebar/sidebar_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 12 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/sync/glue/session_change_processor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model.cc View 7 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_order_controller.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/translate/translate_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/auto_login_prompter.cc View 8 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser.cc View 8 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_tab_restore_service_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/tab_applescript.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_controller.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/login/login_prompt.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/login/login_prompt_browsertest.cc View 16 chunks +30 lines, -41 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_browsertest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/search_engines/search_engine_tab_helper.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_container.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/web_applications/web_app_ui.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/cloud_print_signin_dialog.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/web_ui_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/web_ui_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/base/test_html_dialog_observer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/base/test_tab_strip_model_observer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M content/browser/speech/speech_input_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/ssl/ssl_manager.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M content/browser/tab_contents/interstitial_page.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/tab_contents/navigation_controller_impl.cc View 9 chunks +9 lines, -8 lines 0 comments Download
M content/browser/tab_contents/navigation_controller_impl_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 9 chunks +10 lines, -9 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698