Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: chrome/browser/favicon/favicon_tab_helper.cc

Issue 8983012: Get rid of content::NavigationController in cc file and use "using" instead. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/external_tab_container_win.cc ('k') | chrome/browser/geolocation/geolocation_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_tab_helper.cc
===================================================================
--- chrome/browser/favicon/favicon_tab_helper.cc (revision 116288)
+++ chrome/browser/favicon/favicon_tab_helper.cc (working copy)
@@ -23,6 +23,7 @@
#include "ui/gfx/image/image.h"
using content::FaviconStatus;
+using content::NavigationController;
using content::NavigationEntry;
using content::WebContents;
@@ -48,8 +49,7 @@
SkBitmap FaviconTabHelper::GetFavicon() const {
// Like GetTitle(), we also want to use the favicon for the last committed
// entry rather than a pending navigation entry.
- const content::NavigationController& controller =
- web_contents()->GetController();
+ const NavigationController& controller = web_contents()->GetController();
NavigationEntry* entry = controller.GetTransientEntry();
if (entry)
return entry->GetFavicon().bitmap;
@@ -61,8 +61,7 @@
}
bool FaviconTabHelper::FaviconIsValid() const {
- const content::NavigationController& controller =
- web_contents()->GetController();
+ const NavigationController& controller = web_contents()->GetController();
NavigationEntry* entry = controller.GetTransientEntry();
if (entry)
return entry->GetFavicon().valid;
@@ -76,8 +75,7 @@
bool FaviconTabHelper::ShouldDisplayFavicon() {
// Always display a throbber during pending loads.
- const content::NavigationController& controller =
- web_contents()->GetController();
+ const NavigationController& controller = web_contents()->GetController();
if (controller.GetLastCommittedEntry() && controller.GetPendingEntry())
return true;
@@ -156,8 +154,8 @@
void FaviconTabHelper::NavigateToPendingEntry(
const GURL& url,
- content::NavigationController::ReloadType reload_type) {
- if (reload_type != content::NavigationController::NO_RELOAD &&
+ NavigationController::ReloadType reload_type) {
+ if (reload_type != NavigationController::NO_RELOAD &&
!profile_->IsOffTheRecord()) {
FaviconService* favicon_service =
profile_->GetFaviconService(Profile::IMPLICIT_ACCESS);
« no previous file with comments | « chrome/browser/external_tab_container_win.cc ('k') | chrome/browser/geolocation/geolocation_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698