Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: chrome/browser/tabs/tab_strip_model_unittest.cc

Issue 8983012: Get rid of content::NavigationController in cc file and use "using" instead. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tabs/tab_strip_model_unittest.cc
===================================================================
--- chrome/browser/tabs/tab_strip_model_unittest.cc (revision 116288)
+++ chrome/browser/tabs/tab_strip_model_unittest.cc (working copy)
@@ -41,6 +41,7 @@
#include "testing/gtest/include/gtest/gtest.h"
using content::BrowserThread;
+using content::NavigationController;
using content::WebContents;
using testing::_;
@@ -640,7 +641,7 @@
// background with opener_contents set as their opener.
TabContentsWrapper* opener_contents = CreateTabContents();
- content::NavigationController* opener =
+ NavigationController* opener =
&opener_contents->tab_contents()->GetController();
tabstrip.AppendTabContents(opener_contents, true);
TabContentsWrapper* contents1 = CreateTabContents();
@@ -679,8 +680,7 @@
// For a tab that has opened no other tabs, the return value should always be
// -1...
- content::NavigationController* o1 =
- &contents1->tab_contents()->GetController();
+ NavigationController* o1 = &contents1->tab_contents()->GetController();
EXPECT_EQ(-1, tabstrip.GetIndexOfNextTabContentsOpenedBy(o1, 3, false));
EXPECT_EQ(-1, tabstrip.GetIndexOfLastTabContentsOpenedBy(o1, 3));
@@ -793,7 +793,7 @@
EXPECT_TRUE(tabstrip.empty());
TabContentsWrapper* opener_contents = CreateTabContents();
- content::NavigationController* opener =
+ NavigationController* opener =
&opener_contents->tab_contents()->GetController();
tabstrip.AppendTabContents(opener_contents, true);
« no previous file with comments | « chrome/browser/tabs/tab_strip_model_order_controller.cc ('k') | chrome/browser/translate/translate_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698