Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 8964002: Revert 114229 - Revert 113748 - Provide windows notifictaion of thread termination (Closed)

Created:
9 years ago by jar (doing other things)
Modified:
9 years ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 114229 - Revert 113748 - Provide windows notifictaion of thread termination [This change was shipping to dev/canary over the past weekend, and had no impact on buildability. I'm landing this yet again since the bug has a large impact on XP users, and we need it tested in the field if we are going to push it to M16 in the new year] This code should only have much of an impact on the XP platform, where thread teardown notification are not currently made. Provide an automatic fallback scan of the linker list of notifcation callbacks via DllMain. This fallback is ONLY used if there are no notifications coming via the linker list. This allows all existing code to continue working as it does today, and provides thread teardown notifcatino on XP even though we use the LoadLibrary call. It is a minimal change, suitable for pushing to other channels (beta? stable?). r=cpu BUG=103209 Review URL: http://codereview.chromium.org/8836003 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/8934006 TBR=jar@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114672

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M base/base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + base/win/dllmain.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jar (doing other things)
9 years ago (2011-12-15 19:06:12 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698