Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 8836003: Provide windows notifictaion of thread termination (Closed)

Created:
9 years ago by jar (doing other things)
Modified:
9 years ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Provide windows notifictaion of thread termination This code should only have much of an impact on the XP platform, where thread teardown notification are not currently made. Provide an automatic fallback scan of the linker list of notifcation callbacks via DllMain. This fallback is ONLY used if there are no notifications coming via the linker list. This allows all existing code to continue working as it does today, and provides thread teardown notifcatino on XP even though we use the LoadLibrary call. It is a minimal change, suitable for pushing to other channels (beta? stable?). r=cpu BUG=103209 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113748

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -6 lines) Patch
M base/base.gyp View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A base/win/dllmain.cc View 1 2 3 4 5 6 1 chunk +125 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 4 5 6 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jar (doing other things)
cpu: This is an improved version of the checkin you LGTM'ed Tuesday, which sadly had ...
9 years ago (2011-12-08 07:19:15 UTC) #1
cpu_(ooo_6.6-7.5)
9 years ago (2011-12-08 21:48:34 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698