Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 8934006: Revert 113748 - Provide windows notifictaion of thread termination (Closed)

Created:
9 years ago by jar (doing other things)
Modified:
9 years ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 113748 - Provide windows notifictaion of thread termination [Karen Grunberg requested a speculative revert, because we are currently unable to complete a link of the canary. This change is working fine on the Dev branch, and did not impact the link over the weekend, but for lack of other items, this change is being reverted] This code should only have much of an impact on the XP platform, where thread teardown notification are not currently made. Provide an automatic fallback scan of the linker list of notifcation callbacks via DllMain. This fallback is ONLY used if there are no notifications coming via the linker list. This allows all existing code to continue working as it does today, and provides thread teardown notifcatino on XP even though we use the LoadLibrary call. It is a minimal change, suitable for pushing to other channels (beta? stable?). r=cpu BUG=103209 Review URL: http://codereview.chromium.org/8836003 TBR=jar@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114229

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -127 lines) Patch
M base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D base/win/dllmain.cc View 1 chunk +0 lines, -125 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
jar (doing other things)
9 years ago (2011-12-13 17:48:09 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698