 Chromium Code Reviews
 Chromium Code Reviews Issue 8960011:
  base::Bind: Remove NewRunnableFunction.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 8960011:
  base::Bind: Remove NewRunnableFunction.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: webkit/appcache/appcache_storage_impl.cc | 
| diff --git a/webkit/appcache/appcache_storage_impl.cc b/webkit/appcache/appcache_storage_impl.cc | 
| index e2a0b2697f5f64b2c939352ca27661147bb52810..2b3cf1c8e593465384674984b7ee81367549784d 100644 | 
| --- a/webkit/appcache/appcache_storage_impl.cc | 
| +++ b/webkit/appcache/appcache_storage_impl.cc | 
| @@ -44,11 +44,6 @@ static const FilePath::CharType kDiskCacheDirectoryName[] = | 
| namespace { | 
| -// Helper with no return value for use with NewRunnableFunction. | 
| -void DeleteDirectory(const FilePath& path) { | 
| - file_util::Delete(path, true); | 
| -} | 
| - | 
| // Helpers for clearing data from the AppCacheDatabase. | 
| bool DeleteGroupAndRelatedRecords(AppCacheDatabase* database, | 
| int64 group_id, | 
| @@ -1713,7 +1708,8 @@ void AppCacheStorageImpl::OnDiskCacheInitialized(int rv) { | 
| if (!is_incognito_) { | 
| VLOG(1) << "Deleting existing appcache data and starting over."; | 
| db_thread_->PostTask( | 
| - FROM_HERE, base::Bind(&DeleteDirectory, cache_directory_)); | 
| + FROM_HERE, base::Bind(base::IgnoreResult<bool>(&file_util::Delete), | 
| 
awong
2011/12/27 22:24:15
Do you need the <bool>? here?  That surprises me..
 
James Hawkins
2012/01/01 00:11:46
Yeah, I'm not sure why I wrote that.
 | 
| + cache_directory_, true)); | 
| } | 
| } | 
| } |