Issue 8960011: base::Bind: Remove NewRunnableFunction.

Issue 8960011: base::Bind: Remove NewRunnableFunction. (Closed)

Created:
9 years ago by James Hawkins

Modified:
8 years, 11 months ago

Reviewers:
groby-ooo-7-16, ajwong, awong

CC:
chromium-reviews, michaeln, Alexander Potapenko, sadrul, Timur Iskhodzhanov, brettw-cc_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

base::Bind: Remove NewRunnableFunction. BUG=none TEST=none R=groby,ajwong Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116072

Patch Set 1 #

Patch Set 2 : Build fixes. #

Patch Set 3 : pump as well. #

Patch Set 4 : Win build fix. #

Total comments: 2

Patch Set 5 : One moar. #

Patch Set 6 : Lame TODO. #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -192 lines)			Patch
M	PRESUBMIT.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	base/callback.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/callback.h.pump	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/memory/weak_ptr_unittest.cc	View	1	7 chunks	+9 lines, -19 lines	0 comments	Download
M	base/message_loop_proxy_impl_unittest.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	base/message_pump_glib_unittest.cc	View	1	18 chunks	+69 lines, -59 lines	0 comments	Download
M	base/task.h	View	1 2 3 4	3 chunks	+4 lines, -98 lines	0 comments	Download
M	content/browser/browser_main_loop.cc	View	1 2 3 4	1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/valgrind/common.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/appcache/appcache_storage_impl.cc	View	1 2 3 4 5	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

awong

WOOHOO!!! http://codereview.chromium.org/8960011/diff/6012/webkit/appcache/appcache_storage_impl.cc File webkit/appcache/appcache_storage_impl.cc (right): http://codereview.chromium.org/8960011/diff/6012/webkit/appcache/appcache_storage_impl.cc#newcode1711 webkit/appcache/appcache_storage_impl.cc:1711: FROM_HERE, base::Bind(base::IgnoreResult<bool>(&file_util::Delete), Do you need the <bool>? here? ...

8 years, 12 months ago (2011-12-27 22:24:14 UTC) #3

awong

LGTM after it builds. (btw, my review name is awong, not ajwong...)

8 years, 12 months ago (2011-12-27 22:24:36 UTC) #4

James Hawkins

http://codereview.chromium.org/8960011/diff/6012/webkit/appcache/appcache_storage_impl.cc File webkit/appcache/appcache_storage_impl.cc (right): http://codereview.chromium.org/8960011/diff/6012/webkit/appcache/appcache_storage_impl.cc#newcode1711 webkit/appcache/appcache_storage_impl.cc:1711: FROM_HERE, base::Bind(base::IgnoreResult<bool>(&file_util::Delete), On 2011/12/27 22:24:15, awong wrote: > Do ...

8 years, 11 months ago (2012-01-01 00:11:46 UTC) #5

James Hawkins

On 2012/01/01 00:11:46, James Hawkins wrote: > http://codereview.chromium.org/8960011/diff/6012/webkit/appcache/appcache_storage_impl.cc > File webkit/appcache/appcache_storage_impl.cc (right): > > http://codereview.chromium.org/8960011/diff/6012/webkit/appcache/appcache_storage_impl.cc#newcode1711 ...

8 years, 11 months ago (2012-01-01 02:14:18 UTC) #6

LGTM

Expand Messages | Collapse Messages