base::Bind: Remove NewRunnableFunction.

webkit/appcache/appcache_storage_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/appcache/appcache_storage_impl.h"
 
 #include <algorithm>
 #include <functional>
 #include <set>
 #include <vector>
@@ skipping 26 matching lines @@
 // Hard coded default when not using quota management.
 static const int kDefaultQuota = 5 * 1024 * 1024;
 
 static const int kMaxDiskCacheSize = 250 * 1024 * 1024;
 static const int kMaxMemDiskCacheSize = 10 * 1024 * 1024;
 static const FilePath::CharType kDiskCacheDirectoryName[] =
     FILE_PATH_LITERAL("Cache");
 
 namespace {
 
-// Helper with no return value for use with NewRunnableFunction.
-void DeleteDirectory(const FilePath& path) {
-  file_util::Delete(path, true);
-}
-
 // Helpers for clearing data from the AppCacheDatabase.
 bool DeleteGroupAndRelatedRecords(AppCacheDatabase* database,
                                   int64 group_id,
                                   std::vector<int64>* deletable_response_ids) {
   AppCacheDatabase::CacheRecord cache_record;
   bool success = false;
   if (database->FindCacheForGroup(group_id, &cache_record)) {
     database->FindResponseIdsForCacheAsVector(cache_record.cache_id,
                                               deletable_response_ids);
     success =
@@ skipping 1644 matching lines @@
     AppCacheHistograms::CountInitResult(AppCacheHistograms::DISK_CACHE_ERROR);
 
     // We're unable to open the disk cache, this is a fatal error that we can't
     // really recover from. We handle it by disabling the appcache for this
     // browser session and deleting the directory on disk. The next browser
     // session should start with a clean slate.
     Disable();
     if (!is_incognito_) {
       VLOG(1) << "Deleting existing appcache data and starting over.";
       db_thread_->PostTask(
-          FROM_HERE, base::Bind(&DeleteDirectory, cache_directory_));
+          FROM_HERE, base::Bind(base::IgnoreResult<bool>(&file_util::Delete),

[awong, 2011/12/27 22:24:15]

Do you need the <bool>? here?  That surprises me...

[James Hawkins, 2012/01/01 00:11:46]

Yeah, I'm not sure why I wrote that.

+                                cache_directory_, true));
     }
   }
 }
 
 }  // namespace appcache