Issue 8956014: base::Bind: Cleanup almost-unused OldCompletionCallbacks.

Issue 8956014: base::Bind: Cleanup almost-unused OldCompletionCallbacks. (Closed)

Created:
9 years ago by James Hawkins

Modified:
9 years ago

Reviewers:
dpapad

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

base::Bind: Cleanup almost-unused OldCompletionCallbacks. BUG=none TEST=none R=dpapad Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114674

Patch Set 2 : Win fix. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -136 lines)			Patch
M	chrome/browser/browsing_data_remover.cc	View		1 chunk	+7 lines, -3 lines	0 comments	Download
M	net/disk_cache/backend_impl.h	View		10 chunks	+11 lines, -17 lines	0 comments	Download
M	net/disk_cache/backend_impl.cc	View		3 chunks	+0 lines, -21 lines	0 comments	Download
M	net/disk_cache/disk_cache.h	View		3 chunks	+0 lines, -6 lines	0 comments	Download
M	net/disk_cache/disk_cache_test_base.cc	View		3 chunks	+6 lines, -7 lines	0 comments	Download
M	net/disk_cache/in_flight_backend_io.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	net/disk_cache/in_flight_backend_io.cc	View		3 chunks	+0 lines, -21 lines	0 comments	Download
M	net/disk_cache/mem_backend_impl.h	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	net/disk_cache/mem_backend_impl.cc	View		3 chunks	+0 lines, -24 lines	0 comments	Download
M	net/http/mock_http_cache.h	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	net/http/mock_http_cache.cc	View		2 chunks	+0 lines, -15 lines	0 comments	Download
M	net/tools/dump_cache/upgrade.cc	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	net/url_request/view_cache_helper.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dpapad

LGTM assuming green tryjobs. http://codereview.chromium.org/8956014/diff/1/chrome/browser/browsing_data_remover.cc File chrome/browser/browsing_data_remover.cc (right): http://codereview.chromium.org/8956014/diff/1/chrome/browser/browsing_data_remover.cc#newcode471 chrome/browser/browsing_data_remover.cc:471: rv = factory->GetCache()->GetBackend(&cache_, &cache_callback_); Could ...

9 years ago (2011-12-15 17:27:40 UTC) #2

James Hawkins

9 years ago (2011-12-15 17:54:42 UTC) #3

http://codereview.chromium.org/8956014/diff/1/chrome/browser/browsing_data_re...
File chrome/browser/browsing_data_remover.cc (right):

http://codereview.chromium.org/8956014/diff/1/chrome/browser/browsing_data_re...
chrome/browser/browsing_data_remover.cc:471: rv =
factory->GetCache()->GetBackend(&cache_, &cache_callback_);
On 2011/12/15 17:27:41, dpapad wrote:
> Could this also be replaced?

Not in this CL.

http://codereview.chromium.org/8956014/diff/1/net/disk_cache/disk_cache.h
File net/disk_cache/disk_cache.h (right):

http://codereview.chromium.org/8956014/diff/1/net/disk_cache/disk_cache.h#new...
net/disk_cache/disk_cache.h:114: OldCompletionCallback* callback) = 0;
On 2011/12/15 17:27:41, dpapad wrote:
> Will the remaining |OldCompletionCallback|s converted in another CL?

At some point, yes.

Expand Messages | Collapse Messages