base::Bind: Cleanup almost-unused OldCompletionCallbacks.

net/disk_cache/backend_impl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See net/disk_cache/disk_cache.h for the public interface of the cache.
 
 #ifndef NET_DISK_CACHE_BACKEND_IMPL_H_
 #define NET_DISK_CACHE_BACKEND_IMPL_H_
 #pragma once
 
@@ skipping 47 matching lines @@
                            net::NetLog* net_log, Backend** backend,
                            OldCompletionCallback* callback);
 
   // Performs general initialization for this current instance of the cache.
   int Init(OldCompletionCallback* callback);
 
   // Performs the actual initialization and final cleanup on destruction.
   int SyncInit();
   void CleanupCache();
 
-  // Same bahavior as OpenNextEntry but walks the list from back to front.
+  // Same behavior as OpenNextEntry but walks the list from back to front.
   int OpenPrevEntry(void** iter, Entry** prev_entry,
                     OldCompletionCallback* callback);
 
   // Synchronous implementation of the asynchronous interface.
   int SyncOpenEntry(const std::string& key, Entry** entry);
   int SyncCreateEntry(const std::string& key, Entry** entry);
   int SyncDoomEntry(const std::string& key);
   int SyncDoomAllEntries();
   int SyncDoomEntriesBetween(const base::Time initial_time,
                              const base::Time end_time);
@@ skipping 29 matching lines @@
   bool CreateExternalFile(Addr* address);
 
   // Creates a new storage block of size block_count.
   bool CreateBlock(FileType block_type, int block_count,
                    Addr* block_address);
 
   // Deletes a given storage block. deep set to true can be used to zero-fill
   // the related storage in addition of releasing the related block.
   void DeleteBlock(Addr block_address, bool deep);
 
-  // Retrieves a pointer to the lru-related data.
+  // Retrieves a pointer to the LRU-related data.
   LruData* GetLruData();
 
   // Updates the ranking information for an entry.
   void UpdateRank(EntryImpl* entry, bool modified);
 
   // A node was recovered from a crash, it may not be on the index, so this
   // method checks it and takes the appropriate action.
   void RecoveredEntry(CacheRankingsBlock* rankings);
 
   // Permanently deletes an entry, but still keeps track of it.
@@ skipping 75 matching lines @@
 
   // Reports a critical error (and disables the cache).
   void CriticalError(int error);
 
   // Reports an uncommon, recoverable error.
   void ReportError(int error);
 
   // Called when an interesting event should be logged (counted).
   void OnEvent(Stats::Counters an_event);
 
-  // Keeps track of paylod access (doesn't include metadata).
+  // Keeps track of payload access (doesn't include metadata).
   void OnRead(int bytes);
   void OnWrite(int bytes);
 
   // Timer callback to calculate usage statistics.
   void OnStatsTimer();
 
   // Handles the pending asynchronous IO count.
   void IncrementIoCount();
   void DecrementIoCount();
 
@@ skipping 20 matching lines @@
   int RunTaskForTest(Task* task, OldCompletionCallback* callback);
 
   // Trims an entry (all if |empty| is true) from the list of deleted
   // entries. This method should be called directly on the cache thread.
   void TrimForTest(bool empty);
 
   // Trims an entry (all if |empty| is true) from the list of deleted
   // entries. This method should be called directly on the cache thread.
   void TrimDeletedListForTest(bool empty);
 
-  // Peforms a simple self-check, and returns the number of dirty items
+  // Performs a simple self-check, and returns the number of dirty items
   // or an error code (negative value).
   int SelfCheck();
 
-  // Backend interface.
+  // Backend implementation.
   virtual int32 GetEntryCount() const OVERRIDE;
   virtual int OpenEntry(const std::string& key, Entry** entry,
                         OldCompletionCallback* callback) OVERRIDE;
   virtual int CreateEntry(const std::string& key, Entry** entry,
                           OldCompletionCallback* callback) OVERRIDE;
   virtual int DoomEntry(const std::string& key,
                         OldCompletionCallback* callback) OVERRIDE;
-  virtual int DoomAllEntries(OldCompletionCallback* callback) OVERRIDE;
   virtual int DoomAllEntries(const net::CompletionCallback& callback) OVERRIDE;
-  virtual int DoomEntriesBetween(const base::Time initial_time,
-                                 const base::Time end_time,
-                                 OldCompletionCallback* callback) OVERRIDE;
   virtual int DoomEntriesBetween(
       const base::Time initial_time,
       const base::Time end_time,
       const net::CompletionCallback& callback) OVERRIDE;
   virtual int DoomEntriesSince(const base::Time initial_time,
                                OldCompletionCallback* callback) OVERRIDE;
   virtual int OpenNextEntry(void** iter, Entry** next_entry,
-                            OldCompletionCallback* callback) OVERRIDE;
-  virtual int OpenNextEntry(void** iter, Entry** next_entry,
                             const net::CompletionCallback& callback) OVERRIDE;
   virtual void EndEnumeration(void** iter) OVERRIDE;
   virtual void GetStats(StatsItems* stats) OVERRIDE;
   virtual void OnExternalCacheHit(const std::string& key) OVERRIDE;
 
  private:
   typedef base::hash_map<CacheAddr, EntryImpl*> EntriesMap;
 
   // Creates a new backing file for the cache index.
   bool CreateBackingStore(disk_cache::File* file);
@@ skipping 14 matching lines @@
   // of a given entry, |entry_addr| should be grabbed from that entry, so that
   // if it doesn't match the entry on the index, we know that it was replaced
   // with a new entry; in this case |*match_error| will be set to true and the
   // return value will be NULL.
   EntryImpl* MatchEntry(const std::string& key, uint32 hash, bool find_parent,
                         Addr entry_addr, bool* match_error);
 
   // Opens the next or previous entry on a cache iteration.
   EntryImpl* OpenFollowingEntry(bool forward, void** iter);
 
-  // Opens the next or previous entry on a single list. If successfull,
+  // Opens the next or previous entry on a single list. If successful,
   // |from_entry| will be updated to point to the new entry, otherwise it will
   // be set to NULL; in other words, it is used as an explicit iterator.
   bool OpenFollowingEntryFromList(bool forward, Rankings::List list,
                                   CacheRankingsBlock** from_entry,
                                   EntryImpl** next_entry);
 
   // Returns the entry that is pointed by |next|, from the given |list|.
   EntryImpl* GetEnumeratedEntry(CacheRankingsBlock* next, Rankings::List list);
 
   // Re-opens an entry that was previously deleted.
@@ skipping 16 matching lines @@
 
   // Send UMA stats.
   void ReportStats();
 
   // Upgrades the index file to version 2.1.
   void UpgradeTo2_1();
 
   // Performs basic checks on the index file. Returns false on failure.
   bool CheckIndex();
 
-  // Part of the selt test. Returns the number or dirty entries, or an error.
+  // Part of the self test. Returns the number or dirty entries, or an error.
   int CheckAllEntries();
 
   // Part of the self test. Returns false if the entry is corrupt.
   bool CheckEntry(EntryImpl* cache_entry);
 
   // Returns the maximum total memory for the memory buffers.
   int MaxBuffersSize();
 
   InFlightBackendIO background_queue_;  // The controller of pending operations.
   scoped_refptr<MappedFile> index_;  // The main cache index.
   FilePath path_;  // Path to the folder used as backing storage.
   Index* data_;  // Pointer to the index data.
   BlockFiles block_files_;  // Set of files used to store all data.
   Rankings rankings_;  // Rankings to be able to trim the cache.
   uint32 mask_;  // Binary mask to map a hash to the hash table.
   int32 max_size_;  // Maximum data size for this instance.
   Eviction eviction_;  // Handler of the eviction algorithm.
   EntriesMap open_entries_;  // Map of open entries.
   int num_refs_;  // Number of referenced cache entries.
   int max_refs_;  // Max number of referenced cache entries.
   int num_pending_io_;  // Number of pending IO operations.
   int entry_count_;  // Number of entries accessed lately.
   int byte_count_;  // Number of bytes read/written lately.
   int buffer_bytes_;  // Total size of the temporary entries' buffers.
   int up_ticks_;  // The number of timer ticks received (OnStatsTimer).
   net::CacheType cache_type_;
-  int uma_report_;  // Controls transmision of UMA data.
+  int uma_report_;  // Controls transmission of UMA data.
   uint32 user_flags_;  // Flags set by the user.
   bool init_;  // controls the initialization of the system.
   bool restarted_;
   bool unit_test_;
   bool read_only_;  // Prevents updates of the rankings data (used by tools).
   bool disabled_;
   bool new_eviction_;  // What eviction algorithm should be used.
   bool first_timer_;  // True if the timer has not been called.
   bool user_load_;  // True if we see a high load coming from the caller.
 
   net::NetLog* net_log_;
 
-  Stats stats_;  // Usage statistcs.
+  Stats stats_;  // Usage statistics.
   base::RepeatingTimer<BackendImpl> timer_;  // Usage timer.
   base::WaitableEvent done_;  // Signals the end of background work.
-  scoped_refptr<TraceObject> trace_object_;  // Inits internal tracing.
+  scoped_refptr<TraceObject> trace_object_;  // Initializes internal tracing.
   base::WeakPtrFactory<BackendImpl> ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BackendImpl);
 };
 
-// Returns the prefered max cache size given the available disk space.
+// Returns the preferred max cache size given the available disk space.
 NET_EXPORT_PRIVATE int PreferedCacheSize(int64 available);
 
 }  // namespace disk_cache
 
 #endif  // NET_DISK_CACHE_BACKEND_IMPL_H_