base::Bind: Cleanup almost-unused OldCompletionCallbacks.

net/disk_cache/disk_cache.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Defines the public interface of the disk cache. For more details see
 // http://dev.chromium.org/developers/design-documents/network-stack/disk-cache
 
 #ifndef NET_DISK_CACHE_DISK_CACHE_H_
 #define NET_DISK_CACHE_DISK_CACHE_H_
 #pragma once
@@ skipping 79 matching lines @@
 
   // Marks the entry, specified by the given key, for deletion. The return value
   // is a net error code. If this method returns ERR_IO_PENDING, the |callback|
   // will be invoked after the entry is doomed.
   virtual int DoomEntry(const std::string& key,
                         OldCompletionCallback* callback) = 0;
 
   // Marks all entries for deletion. The return value is a net error code. If
   // this method returns ERR_IO_PENDING, the |callback| will be invoked when the
   // operation completes.
-  virtual int DoomAllEntries(OldCompletionCallback* callback) = 0;
   virtual int DoomAllEntries(const net::CompletionCallback& callback) = 0;
 
   // Marks a range of entries for deletion. This supports unbounded deletes in
   // either direction by using null Time values for either argument. The return
   // value is a net error code. If this method returns ERR_IO_PENDING, the
   // |callback| will be invoked when the operation completes.
   virtual int DoomEntriesBetween(const base::Time initial_time,
                                  const base::Time end_time,
-                                 OldCompletionCallback* callback) = 0;
-  virtual int DoomEntriesBetween(const base::Time initial_time,
-                                 const base::Time end_time,
                                  const net::CompletionCallback& callback) = 0;
 
   // Marks all entries accessed since |initial_time| for deletion. The return
   // value is a net error code. If this method returns ERR_IO_PENDING, the
   // |callback| will be invoked when the operation completes.
   virtual int DoomEntriesSince(const base::Time initial_time,
                                OldCompletionCallback* callback) = 0;

[dpapad, 2011/12/15 17:27:41]

Will the remaining |OldCompletionCallback|s converted in another CL?

[James Hawkins, 2011/12/15 17:54:42]

At some point, yes.

 
   // Enumerates the cache. Initialize |iter| to NULL before calling this method
   // the first time. That will cause the enumeration to start at the head of
   // the cache. For subsequent calls, pass the same |iter| pointer again without
   // changing its value. This method returns ERR_FAILED when there are no more
   // entries to enumerate. When the entry pointer is no longer needed, its
   // Close method should be called. The return value is a net error code. If
   // this method returns ERR_IO_PENDING, the |callback| will be invoked when the
   // |next_entry| is available. The pointer to receive the |next_entry| must
   // remain valid until the operation completes.
   //
   // NOTE: This method does not modify the last_used field of the entry, and
   // therefore it does not impact the eviction ranking of the entry.
   virtual int OpenNextEntry(void** iter, Entry** next_entry,
-                            OldCompletionCallback* callback) = 0;
-  virtual int OpenNextEntry(void** iter, Entry** next_entry,
                             const net::CompletionCallback& callback) = 0;
 
   // Releases iter without returning the next entry. Whenever OpenNextEntry()
   // returns true, but the caller is not interested in continuing the
   // enumeration by calling OpenNextEntry() again, the enumeration must be
   // ended by calling this method with iter returned by OpenNextEntry().
   virtual void EndEnumeration(void** iter) = 0;
 
   // Return a list of cache statistics.
   virtual void GetStats(
@@ skipping 156 matching lines @@
   // Note: This method is deprecated.
   virtual int ReadyForSparseIO(OldCompletionCallback* completion_callback) = 0;
 
  protected:
   virtual ~Entry() {}
 };
 
 }  // namespace disk_cache
 
 #endif  // NET_DISK_CACHE_DISK_CACHE_H_