Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 8949061: Move a bunch of methods from TabContents into the WebContents interface. This change either moves... (Closed)

Created:
9 years ago by jam
Modified:
9 years ago
Reviewers:
tburkard
CC:
chromium-reviews, jstritar+watch_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, nkostylev+watch_chromium.org, tbarzic+watch_chromium.org, achuith+watch_chromium.org, ajwong+watch_chromium.org, jam, mihaip+watch_chromium.org, dcheng, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, Paweł Hajdan Jr., darin-cc_chromium.org, rdsmith+dwatch_chromium.org, brettw-cc_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move a bunch of methods from TabContents into the WebContents interface. This change either moves CamelCase functions into the interface, or renames existing unix_hacker functions to CamelCase. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115495

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+406 lines, -320 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_manager_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/instant/instant_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/oom_priority_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_preview_message_handler.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/window_applescript.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_titlebar.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/tab_contents_wrapper_synced_tab_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/aura/app_list_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_drag_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/default_tab_drag_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/imageburner/imageburner_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/cloud_print_signin_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview_ui.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_ui_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/render_view_host_manager_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 2 8 chunks +39 lines, -128 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 14 chunks +144 lines, -75 lines 0 comments Download
M content/browser/tab_contents/tab_contents_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/tab_contents/web_drag_source_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/web_drag_source_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webkit_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/web_contents.h View 1 2 chunks +105 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
9 years ago (2011-12-22 00:18:27 UTC) #1
tburkard
9 years ago (2011-12-22 00:27:04 UTC) #2
LGTM

On Wed, Dec 21, 2011 at 4:18 PM, <jam@chromium.org> wrote:

> Reviewers: tburkard,
>
> Description:
> Move a bunch of methods from TabContents into the WebContents interface.
> This
> change either moves CamelCase functions into the interface, or renames
> existing
> unix_hacker functions to CamelCase.
>
> BUG=98716
>
> Please review this at
http://codereview.chromium.**org/8949061/<http://codereview.chromium.org/8949...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>
> Affected files:
>  M     chrome/browser/bookmarks/**bookmark_manager_extension_**api.cc
>  M     chrome/browser/chromeos/login/**webui_login_view.cc
>  M     chrome/browser/download/**download_browsertest.cc
>  M     chrome/browser/download/save_**page_browsertest.cc
>  M     chrome/browser/extensions/app_**process_apitest.cc
>  M     chrome/browser/geolocation/**chrome_geolocation_permission_**
> context_unittest.cc
>  M     chrome/browser/instant/**instant_loader.cc
>  M     chrome/browser/oom_priority_**manager.cc
>  M     chrome/browser/printing/print_**preview_message_handler.cc
>  M     chrome/browser/printing/print_**preview_tab_controller.cc
>  M     chrome/browser/printing/print_**view_manager.cc
>  M     chrome/browser/safe_browsing/**safe_browsing_blocking_page.cc
>  M     chrome/browser/ssl/ssl_**browser_tests.cc
>  M     chrome/browser/ui/blocked_**content/blocked_content_tab_**helper.cc
>  M     chrome/browser/ui/bookmarks/**bookmark_tab_helper.cc
>  M     chrome/browser/ui/browser.cc
>  M     chrome/browser/ui/browser_**navigator.cc
>  M     chrome/browser/ui/browser_**navigator_browsertest.cc
>  M    
chrome/browser/ui/cocoa/**applescript/window_**applescript.mm<http://window_applescript.mm>
>  M    
chrome/browser/ui/cocoa/browse**r_window_controller.mm<http://browser_window_controller.mm>
>  M    
chrome/browser/ui/cocoa/tabs/t**ab_strip_controller.mm<http://tab_strip_controller.mm>
>  M     chrome/browser/ui/gtk/browser_**titlebar.cc
>  M     chrome/browser/ui/gtk/browser_**window_gtk.cc
>  M     chrome/browser/ui/gtk/tabs/**dragged_tab_controller_gtk.cc
>  M     chrome/browser/ui/gtk/tabs/**tab_renderer_gtk.cc
>  M     chrome/browser/ui/sync/tab_**contents_wrapper_synced_tab_**
> delegate.cc
>  M     chrome/browser/ui/tab_**contents/core_tab_helper.cc
>  M     chrome/browser/ui/toolbar/**wrench_menu_model.cc
>  M     chrome/browser/ui/views/aura/**app_list_window.cc
>  M     chrome/browser/ui/views/frame/**browser_view.cc
>  M     chrome/browser/ui/views/tab_**contents/native_tab_contents_**
> container_aura.cc
>  M     chrome/browser/ui/views/tab_**contents/native_tab_contents_**
> container_gtk.cc
>  M     chrome/browser/ui/views/tab_**contents/native_tab_contents_**
> container_win.cc
>  M     chrome/browser/ui/views/tab_**contents/tab_contents_view_**views.cc
>  M     chrome/browser/ui/views/tabs/**browser_tab_strip_controller.**cc
>  M     chrome/browser/ui/views/tabs/**default_tab_drag_controller.cc
>  M     chrome/browser/ui/webui/**chromeos/imageburner/**
> imageburner_utils.cc
>  M     chrome/browser/ui/webui/**chromeos/mobile_setup_ui.cc
>  M     chrome/browser/ui/webui/cloud_**print_signin_dialog.cc
>  M     chrome/browser/ui/webui/html_**dialog_tab_contents_delegate.**cc
>  M     chrome/browser/ui/webui/print_**preview_handler_unittest.cc
>  M     chrome/browser/ui/webui/print_**preview_ui.cc
>  M     chrome/browser/ui/webui/print_**preview_ui_unittest.cc
>  M     chrome/browser/ui/webui/web_**ui_browsertest.cc
>  M     chrome/browser/ui/webui/web_**ui_unittest.cc
>  M     chrome/test/base/browser_with_**test_window_test.cc
>  M     content/browser/renderer_host/**render_view_host_manager_**
> browsertest.cc
>  M     content/browser/renderer_host/**test_render_view_host.cc
>  M     content/browser/ssl/ssl_**policy.cc
>  M     content/browser/tab_contents/**render_view_host_manager_**
> unittest.cc
>  M     content/browser/tab_contents/**tab_contents.h
>  M     content/browser/tab_contents/**tab_contents.cc
>  M     content/browser/tab_contents/**tab_contents_unittest.cc
>  M     content/browser/tab_contents/**web_drag_source_gtk.cc
>  M    
content/browser/tab_contents/w**eb_drag_source_mac.mm<http://web_drag_source_mac.mm>
>  M     content/browser/webkit_**browsertest.cc
>  M     content/public/browser/web_**contents.h
>
>
>

Powered by Google App Engine
This is Rietveld 408576698