chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc - Issue 8949061: Move a bunch of methods from TabContents into the WebContents interface. This change either moves...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

Issue 8949061: Move a bunch of methods from TabContents into the WebContents interface. This change either moves... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc ('k') | chrome/browser/ui/views/tabs/default_tab_drag_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

===================================================================

--- chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc (revision 115435)

+++ chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc (working copy)

@@ -33,7 +33,7 @@

TabContents* contents) {

if (!contents || !contents->IsLoading())

return TabRendererData::NETWORK_STATE_NONE;

- if (contents->waiting_for_response())

+ if (contents->IsWaitingForResponse())

return TabRendererData::NETWORK_STATE_WAITING;

return TabRendererData::NETWORK_STATE_LOADING;

}

@@ -437,7 +437,7 @@

data->title = contents->GetTitle();

data->url = contents->GetURL();

data->loading = contents->IsLoading();

- data->crashed_status = contents->crashed_status();

+ data->crashed_status = contents->GetCrashedStatus();

data->incognito = contents->GetBrowserContext()->IsOffTheRecord();

data->show_icon = wrapper->favicon_tab_helper()->ShouldDisplayFavicon();

data->mini = model_->IsMiniTab(model_index);