Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1677)

Unified Diff: chrome/browser/extensions/app_process_apitest.cc

Issue 8949061: Move a bunch of methods from TabContents into the WebContents interface. This change either moves... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/app_process_apitest.cc
===================================================================
--- chrome/browser/extensions/app_process_apitest.cc (revision 115435)
+++ chrome/browser/extensions/app_process_apitest.cc (working copy)
@@ -109,7 +109,7 @@
ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
EXPECT_TRUE(process_map->Contains(
browser()->GetTabContentsAt(1)->GetRenderProcessHost()->GetID()));
- EXPECT_FALSE(browser()->GetTabContentsAt(1)->web_ui());
+ EXPECT_FALSE(browser()->GetTabContentsAt(1)->GetWebUI());
LOG(INFO) << "Nav 1.";
ui_test_utils::NavigateToURLWithDisposition(
@@ -117,7 +117,7 @@
ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
EXPECT_TRUE(process_map->Contains(
browser()->GetTabContentsAt(2)->GetRenderProcessHost()->GetID()));
- EXPECT_FALSE(browser()->GetTabContentsAt(2)->web_ui());
+ EXPECT_FALSE(browser()->GetTabContentsAt(2)->GetWebUI());
LOG(INFO) << "Nav 2.";
ui_test_utils::WindowedNotificationObserver tab_added_observer(
@@ -130,7 +130,7 @@
LOG(INFO) << "Nav 3.";
EXPECT_FALSE(process_map->Contains(
browser()->GetTabContentsAt(3)->GetRenderProcessHost()->GetID()));
- EXPECT_FALSE(browser()->GetTabContentsAt(3)->web_ui());
+ EXPECT_FALSE(browser()->GetTabContentsAt(3)->GetWebUI());
// We should have opened 3 new extension tabs. Including the original blank
// tab, we now have 4 tabs. Because the app_process app has the background
@@ -221,7 +221,7 @@
LOG(INFO) << "Nav 1.";
EXPECT_TRUE(process_map->Contains(
browser()->GetTabContentsAt(1)->GetRenderProcessHost()->GetID()));
- EXPECT_FALSE(browser()->GetTabContentsAt(1)->web_ui());
+ EXPECT_FALSE(browser()->GetTabContentsAt(1)->GetWebUI());
ui_test_utils::WindowedNotificationObserver tab_added_observer(
content::NOTIFICATION_TAB_ADDED,
@@ -233,7 +233,7 @@
LOG(INFO) << "Nav 2.";
EXPECT_TRUE(process_map->Contains(
browser()->GetTabContentsAt(2)->GetRenderProcessHost()->GetID()));
- EXPECT_FALSE(browser()->GetTabContentsAt(2)->web_ui());
+ EXPECT_FALSE(browser()->GetTabContentsAt(2)->GetWebUI());
// We should have opened 2 new extension tabs. Including the original blank
// tab, we now have 3 tabs. The two app tabs should not be in the same
@@ -287,7 +287,7 @@
ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
EXPECT_FALSE(process_map->Contains(
browser()->GetTabContentsAt(1)->GetRenderProcessHost()->GetID()));
- EXPECT_FALSE(browser()->GetTabContentsAt(1)->web_ui());
+ EXPECT_FALSE(browser()->GetTabContentsAt(1)->GetWebUI());
ui_test_utils::WindowedNotificationObserver tab_added_observer(
content::NOTIFICATION_TAB_ADDED,
@@ -297,7 +297,7 @@
ui_test_utils::NavigateToURL(browser(), base_url.Resolve("path2/empty.html"));
EXPECT_FALSE(process_map->Contains(
browser()->GetTabContentsAt(2)->GetRenderProcessHost()->GetID()));
- EXPECT_FALSE(browser()->GetTabContentsAt(2)->web_ui());
+ EXPECT_FALSE(browser()->GetTabContentsAt(2)->GetWebUI());
// We should have opened 2 new bookmark app tabs. Including the original blank
// tab, we now have 3 tabs. Because normal pages use the

Powered by Google App Engine
This is Rietveld 408576698