Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Version for commit (merged again). Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc b/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc
index 5e6442b902f99e1afce205886d60bccd6c710b5f..f9b337eaa6b6cbfd5a05c68157e908e647c46f63 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc
@@ -16,10 +16,12 @@
#include "chrome/browser/ui/browser_list.h"
#include "chrome/common/pref_names.h"
#include "content/browser/tab_contents/page_navigator.h"
-#include "content/browser/user_metrics.h"
+#include "content/public/browser/user_metrics.h"
#include "grit/generated_resources.h"
#include "ui/views/widget/widget.h"
+using content::UserMetricsAction;
+
BookmarkContextMenuControllerViews::BookmarkContextMenuControllerViews(
views::Widget* parent_widget,
BookmarkContextMenuControllerViewsDelegate* delegate,
@@ -101,15 +103,15 @@ void BookmarkContextMenuControllerViews::ExecuteCommand(int id) {
WindowOpenDisposition initial_disposition;
if (id == IDC_BOOKMARK_BAR_OPEN_ALL) {
initial_disposition = NEW_FOREGROUND_TAB;
- UserMetrics::RecordAction(
+ content::RecordAction(
UserMetricsAction("BookmarkBar_ContextMenu_OpenAll"));
} else if (id == IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW) {
initial_disposition = NEW_WINDOW;
- UserMetrics::RecordAction(
+ content::RecordAction(
UserMetricsAction("BookmarkBar_ContextMenu_OpenAllInNewWindow"));
} else {
initial_disposition = OFF_THE_RECORD;
- UserMetrics::RecordAction(
+ content::RecordAction(
UserMetricsAction("BookmarkBar_ContextMenu_OpenAllIncognito"));
}
bookmark_utils::OpenAll(parent_widget_->GetNativeWindow(),
@@ -121,7 +123,7 @@ void BookmarkContextMenuControllerViews::ExecuteCommand(int id) {
case IDC_BOOKMARK_BAR_RENAME_FOLDER:
case IDC_BOOKMARK_BAR_EDIT:
- UserMetrics::RecordAction(
+ content::RecordAction(
UserMetricsAction("BookmarkBar_ContextMenu_Edit"));
if (selection_.size() != 1) {
@@ -137,7 +139,7 @@ void BookmarkContextMenuControllerViews::ExecuteCommand(int id) {
break;
case IDC_BOOKMARK_BAR_REMOVE: {
- UserMetrics::RecordAction(
+ content::RecordAction(
UserMetricsAction("BookmarkBar_ContextMenu_Remove"));
delegate_->WillRemoveBookmarks(selection_);
@@ -151,7 +153,7 @@ void BookmarkContextMenuControllerViews::ExecuteCommand(int id) {
}
case IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK: {
- UserMetrics::RecordAction(
+ content::RecordAction(
UserMetricsAction("BookmarkBar_ContextMenu_Add"));
int index;
@@ -166,7 +168,7 @@ void BookmarkContextMenuControllerViews::ExecuteCommand(int id) {
}
case IDC_BOOKMARK_BAR_NEW_FOLDER: {
- UserMetrics::RecordAction(
+ content::RecordAction(
UserMetricsAction("BookmarkBar_ContextMenu_NewFolder"));
int index;
@@ -185,7 +187,7 @@ void BookmarkContextMenuControllerViews::ExecuteCommand(int id) {
break;
case IDC_BOOKMARK_MANAGER: {
- UserMetrics::RecordAction(UserMetricsAction("ShowBookmarkManager"));
+ content::RecordAction(UserMetricsAction("ShowBookmarkManager"));
Browser* browser = BrowserList::GetLastActiveWithProfile(profile_);
if (!browser) NOTREACHED();

Powered by Google App Engine
This is Rietveld 408576698