Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1442)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Version for commit (merged again). Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
index ef4988a9d6ca96fbac9f01245959304118809568..2e9e44f3d7d258ccb85fc1d572ee2db78e0a3bb2 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
@@ -16,8 +16,8 @@
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/views/window.h"
#include "chrome/common/chrome_notification_types.h"
-#include "content/browser/user_metrics.h"
#include "content/public/browser/notification_service.h"
+#include "content/public/browser/user_metrics.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
#include "ui/base/keycodes/keyboard_codes.h"
@@ -33,6 +33,7 @@
#include "ui/views/layout/layout_constants.h"
#include "ui/views/widget/widget.h"
+using content::UserMetricsAction;
using views::ColumnSet;
using views::GridLayout;
@@ -272,7 +273,7 @@ void BookmarkBubbleView::ButtonPressed(
void BookmarkBubbleView::LinkClicked(views::Link* source, int event_flags) {
DCHECK(source == remove_link_);
- UserMetrics::RecordAction(UserMetricsAction("BookmarkBubble_Unstar"));
+ content::RecordAction(UserMetricsAction("BookmarkBubble_Unstar"));
// Set this so we remove the bookmark after the window closes.
remove_bookmark_ = true;
@@ -284,15 +285,15 @@ void BookmarkBubbleView::ItemChanged(views::Combobox* combo_box,
int prev_index,
int new_index) {
if (new_index + 1 == parent_model_.GetItemCount()) {
- UserMetrics::RecordAction(
- UserMetricsAction("BookmarkBubble_EditFromCombobox"));
+ content::RecordAction(
+ UserMetricsAction("BookmarkBubble_EditFromCombobox"));
ShowEditor();
}
}
void BookmarkBubbleView::HandleButtonPressed(views::Button* sender) {
if (sender == edit_button_) {
- UserMetrics::RecordAction(UserMetricsAction("BookmarkBubble_Edit"));
+ content::RecordAction(UserMetricsAction("BookmarkBubble_Edit"));
ShowEditor();
} else {
DCHECK_EQ(sender, close_button_);
@@ -324,7 +325,7 @@ void BookmarkBubbleView::ApplyEdits() {
const string16 new_title = title_tf_->text();
if (new_title != node->GetTitle()) {
model->SetTitle(node, new_title);
- UserMetrics::RecordAction(
+ content::RecordAction(
UserMetricsAction("BookmarkBubble_ChangeTitleInBubble"));
}
// Last index means 'Choose another folder...'
@@ -332,7 +333,7 @@ void BookmarkBubbleView::ApplyEdits() {
const BookmarkNode* new_parent =
parent_model_.GetNodeAt(parent_combobox_->selected_item());
if (new_parent != node->parent()) {
- UserMetrics::RecordAction(
+ content::RecordAction(
UserMetricsAction("BookmarkBubble_ChangeParent"));
model->Move(node, new_parent, new_parent->child_count());
}

Powered by Google App Engine
This is Rietveld 408576698