Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Side by Side Diff: chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Version for commit (merged again). Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_vie ws.h" 5 #include "chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_vie ws.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "chrome/app/chrome_command_ids.h" 8 #include "chrome/app/chrome_command_ids.h"
9 #include "chrome/browser/bookmarks/bookmark_editor.h" 9 #include "chrome/browser/bookmarks/bookmark_editor.h"
10 #include "chrome/browser/bookmarks/bookmark_model.h" 10 #include "chrome/browser/bookmarks/bookmark_model.h"
11 #include "chrome/browser/bookmarks/bookmark_utils.h" 11 #include "chrome/browser/bookmarks/bookmark_utils.h"
12 #include "chrome/browser/prefs/incognito_mode_prefs.h" 12 #include "chrome/browser/prefs/incognito_mode_prefs.h"
13 #include "chrome/browser/prefs/pref_service.h" 13 #include "chrome/browser/prefs/pref_service.h"
14 #include "chrome/browser/profiles/profile.h" 14 #include "chrome/browser/profiles/profile.h"
15 #include "chrome/browser/ui/browser.h" 15 #include "chrome/browser/ui/browser.h"
16 #include "chrome/browser/ui/browser_list.h" 16 #include "chrome/browser/ui/browser_list.h"
17 #include "chrome/common/pref_names.h" 17 #include "chrome/common/pref_names.h"
18 #include "content/browser/tab_contents/page_navigator.h" 18 #include "content/browser/tab_contents/page_navigator.h"
19 #include "content/browser/user_metrics.h" 19 #include "content/public/browser/user_metrics.h"
20 #include "grit/generated_resources.h" 20 #include "grit/generated_resources.h"
21 #include "ui/views/widget/widget.h" 21 #include "ui/views/widget/widget.h"
22 22
23 using content::UserMetricsAction;
24
23 BookmarkContextMenuControllerViews::BookmarkContextMenuControllerViews( 25 BookmarkContextMenuControllerViews::BookmarkContextMenuControllerViews(
24 views::Widget* parent_widget, 26 views::Widget* parent_widget,
25 BookmarkContextMenuControllerViewsDelegate* delegate, 27 BookmarkContextMenuControllerViewsDelegate* delegate,
26 Profile* profile, 28 Profile* profile,
27 PageNavigator* navigator, 29 PageNavigator* navigator,
28 const BookmarkNode* parent, 30 const BookmarkNode* parent,
29 const std::vector<const BookmarkNode*>& selection) 31 const std::vector<const BookmarkNode*>& selection)
30 : parent_widget_(parent_widget), 32 : parent_widget_(parent_widget),
31 delegate_(delegate), 33 delegate_(delegate),
32 profile_(profile), 34 profile_(profile),
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 void BookmarkContextMenuControllerViews::ExecuteCommand(int id) { 96 void BookmarkContextMenuControllerViews::ExecuteCommand(int id) {
95 BookmarkModel* model = RemoveModelObserver(); 97 BookmarkModel* model = RemoveModelObserver();
96 98
97 switch (id) { 99 switch (id) {
98 case IDC_BOOKMARK_BAR_OPEN_ALL: 100 case IDC_BOOKMARK_BAR_OPEN_ALL:
99 case IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO: 101 case IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO:
100 case IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW: { 102 case IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW: {
101 WindowOpenDisposition initial_disposition; 103 WindowOpenDisposition initial_disposition;
102 if (id == IDC_BOOKMARK_BAR_OPEN_ALL) { 104 if (id == IDC_BOOKMARK_BAR_OPEN_ALL) {
103 initial_disposition = NEW_FOREGROUND_TAB; 105 initial_disposition = NEW_FOREGROUND_TAB;
104 UserMetrics::RecordAction( 106 content::RecordAction(
105 UserMetricsAction("BookmarkBar_ContextMenu_OpenAll")); 107 UserMetricsAction("BookmarkBar_ContextMenu_OpenAll"));
106 } else if (id == IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW) { 108 } else if (id == IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW) {
107 initial_disposition = NEW_WINDOW; 109 initial_disposition = NEW_WINDOW;
108 UserMetrics::RecordAction( 110 content::RecordAction(
109 UserMetricsAction("BookmarkBar_ContextMenu_OpenAllInNewWindow")); 111 UserMetricsAction("BookmarkBar_ContextMenu_OpenAllInNewWindow"));
110 } else { 112 } else {
111 initial_disposition = OFF_THE_RECORD; 113 initial_disposition = OFF_THE_RECORD;
112 UserMetrics::RecordAction( 114 content::RecordAction(
113 UserMetricsAction("BookmarkBar_ContextMenu_OpenAllIncognito")); 115 UserMetricsAction("BookmarkBar_ContextMenu_OpenAllIncognito"));
114 } 116 }
115 bookmark_utils::OpenAll(parent_widget_->GetNativeWindow(), 117 bookmark_utils::OpenAll(parent_widget_->GetNativeWindow(),
116 profile_, navigator_, selection_, 118 profile_, navigator_, selection_,
117 initial_disposition); 119 initial_disposition);
118 bookmark_utils::RecordBookmarkLaunch(bookmark_utils::LAUNCH_CONTEXT_MENU); 120 bookmark_utils::RecordBookmarkLaunch(bookmark_utils::LAUNCH_CONTEXT_MENU);
119 break; 121 break;
120 } 122 }
121 123
122 case IDC_BOOKMARK_BAR_RENAME_FOLDER: 124 case IDC_BOOKMARK_BAR_RENAME_FOLDER:
123 case IDC_BOOKMARK_BAR_EDIT: 125 case IDC_BOOKMARK_BAR_EDIT:
124 UserMetrics::RecordAction( 126 content::RecordAction(
125 UserMetricsAction("BookmarkBar_ContextMenu_Edit")); 127 UserMetricsAction("BookmarkBar_ContextMenu_Edit"));
126 128
127 if (selection_.size() != 1) { 129 if (selection_.size() != 1) {
128 NOTREACHED(); 130 NOTREACHED();
129 return; 131 return;
130 } 132 }
131 133
132 BookmarkEditor::Show( 134 BookmarkEditor::Show(
133 parent_widget_->GetNativeWindow(), 135 parent_widget_->GetNativeWindow(),
134 profile_, 136 profile_,
135 BookmarkEditor::EditDetails::EditNode(selection_[0]), 137 BookmarkEditor::EditDetails::EditNode(selection_[0]),
136 BookmarkEditor::SHOW_TREE); 138 BookmarkEditor::SHOW_TREE);
137 break; 139 break;
138 140
139 case IDC_BOOKMARK_BAR_REMOVE: { 141 case IDC_BOOKMARK_BAR_REMOVE: {
140 UserMetrics::RecordAction( 142 content::RecordAction(
141 UserMetricsAction("BookmarkBar_ContextMenu_Remove")); 143 UserMetricsAction("BookmarkBar_ContextMenu_Remove"));
142 144
143 delegate_->WillRemoveBookmarks(selection_); 145 delegate_->WillRemoveBookmarks(selection_);
144 for (size_t i = 0; i < selection_.size(); ++i) { 146 for (size_t i = 0; i < selection_.size(); ++i) {
145 model->Remove(selection_[i]->parent(), 147 model->Remove(selection_[i]->parent(),
146 selection_[i]->parent()->GetIndexOf(selection_[i])); 148 selection_[i]->parent()->GetIndexOf(selection_[i]));
147 } 149 }
148 delegate_->DidRemoveBookmarks(); 150 delegate_->DidRemoveBookmarks();
149 selection_.clear(); 151 selection_.clear();
150 break; 152 break;
151 } 153 }
152 154
153 case IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK: { 155 case IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK: {
154 UserMetrics::RecordAction( 156 content::RecordAction(
155 UserMetricsAction("BookmarkBar_ContextMenu_Add")); 157 UserMetricsAction("BookmarkBar_ContextMenu_Add"));
156 158
157 int index; 159 int index;
158 const BookmarkNode* parent = 160 const BookmarkNode* parent =
159 bookmark_utils::GetParentForNewNodes(parent_, selection_, &index); 161 bookmark_utils::GetParentForNewNodes(parent_, selection_, &index);
160 BookmarkEditor::Show( 162 BookmarkEditor::Show(
161 parent_widget_->GetNativeWindow(), 163 parent_widget_->GetNativeWindow(),
162 profile_, 164 profile_,
163 BookmarkEditor::EditDetails::AddNodeInFolder(parent, index), 165 BookmarkEditor::EditDetails::AddNodeInFolder(parent, index),
164 BookmarkEditor::SHOW_TREE); 166 BookmarkEditor::SHOW_TREE);
165 break; 167 break;
166 } 168 }
167 169
168 case IDC_BOOKMARK_BAR_NEW_FOLDER: { 170 case IDC_BOOKMARK_BAR_NEW_FOLDER: {
169 UserMetrics::RecordAction( 171 content::RecordAction(
170 UserMetricsAction("BookmarkBar_ContextMenu_NewFolder")); 172 UserMetricsAction("BookmarkBar_ContextMenu_NewFolder"));
171 173
172 int index; 174 int index;
173 const BookmarkNode* parent = 175 const BookmarkNode* parent =
174 bookmark_utils::GetParentForNewNodes(parent_, selection_, &index); 176 bookmark_utils::GetParentForNewNodes(parent_, selection_, &index);
175 BookmarkEditor::Show( 177 BookmarkEditor::Show(
176 parent_widget_->GetNativeWindow(), 178 parent_widget_->GetNativeWindow(),
177 profile_, 179 profile_,
178 BookmarkEditor::EditDetails::AddFolder(parent, index), 180 BookmarkEditor::EditDetails::AddFolder(parent, index),
179 BookmarkEditor::SHOW_TREE); 181 BookmarkEditor::SHOW_TREE);
180 break; 182 break;
181 } 183 }
182 184
183 case IDC_BOOKMARK_BAR_ALWAYS_SHOW: 185 case IDC_BOOKMARK_BAR_ALWAYS_SHOW:
184 bookmark_utils::ToggleWhenVisible(profile_); 186 bookmark_utils::ToggleWhenVisible(profile_);
185 break; 187 break;
186 188
187 case IDC_BOOKMARK_MANAGER: { 189 case IDC_BOOKMARK_MANAGER: {
188 UserMetrics::RecordAction(UserMetricsAction("ShowBookmarkManager")); 190 content::RecordAction(UserMetricsAction("ShowBookmarkManager"));
189 Browser* browser = BrowserList::GetLastActiveWithProfile(profile_); 191 Browser* browser = BrowserList::GetLastActiveWithProfile(profile_);
190 if (!browser) NOTREACHED(); 192 if (!browser) NOTREACHED();
191 193
192 if (selection_.size() != 1) 194 if (selection_.size() != 1)
193 browser->OpenBookmarkManager(); 195 browser->OpenBookmarkManager();
194 else if (selection_[0]->is_folder()) 196 else if (selection_[0]->is_folder())
195 browser->OpenBookmarkManagerForNode(selection_[0]->id()); 197 browser->OpenBookmarkManagerForNode(selection_[0]->id());
196 else if (parent_) 198 else if (parent_)
197 browser->OpenBookmarkManagerForNode(parent_->id()); 199 browser->OpenBookmarkManagerForNode(parent_->id());
198 else 200 else
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 return model; 299 return model;
298 } 300 }
299 301
300 bool BookmarkContextMenuControllerViews::HasURLs() const { 302 bool BookmarkContextMenuControllerViews::HasURLs() const {
301 for (size_t i = 0; i < selection_.size(); ++i) { 303 for (size_t i = 0; i < selection_.size(); ++i) {
302 if (bookmark_utils::NodeHasURLs(selection_[i])) 304 if (bookmark_utils::NodeHasURLs(selection_[i]))
303 return true; 305 return true;
304 } 306 }
305 return false; 307 return false;
306 } 308 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698